Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename worker arguments to match the names used by Bunny #54

Merged
merged 1 commit into from Jul 6, 2014

Conversation

@norman
Copy link
Contributor

commented Jun 27, 2014

This changes the names of the variables passed to Sneakers workers, so that they match the names used in Bunny. Reading the source code of both libraries is confusing because of the arbitrarily different names.

It also makes the code seem odd when delivery_info is referred to as hdrs, because that implies they are "headers", but the props (now metadata) argument contains a "headers" key. For example:

def work_with_params(msg, hdrs, props)
  headers = props[:headers] # if these are "headers", what are "hdrs"?
  ...
end
@jondot

This comment has been minimized.

Copy link
Owner

commented Jul 6, 2014

Excellent feedback! thanks 👍

jondot added a commit that referenced this pull request Jul 6, 2014

Merge pull request #54 from flexminder/improve_worker_variable_names
Rename worker arguments to match the names used by Bunny

@jondot jondot merged commit 40004f6 into jondot:master Jul 6, 2014

@norman norman deleted the improve_worker_variable_names branch Jul 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.