Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration class #56

Merged
merged 3 commits into from Jul 11, 2014

Conversation

@norman
Copy link
Contributor

commented Jul 10, 2014

This pull request adds a configuration class to Sneakers. Its primary purpose is to move the code that reads the RABBITMQ_URL environment variable out of a class definition and into an object that can be tested.

@jondot sorry I'm sending this a bit later than promised, take a look and let me know if you agree with the approach.

norman added some commits Jul 10, 2014

Added Configuration class
This will allow us to test the intitialization of configuration
Rename "Config" to "CONFIG"
It's a near universal convention in Ruby that constants are all upper
case, with PascalCase resevered for Class and Module names. Having the
configuration information saved in a constant with Pascal case makes the
code less clear to programmers who are used to this convention.
@jondot

This comment has been minimized.

Copy link
Owner

commented Jul 11, 2014

It's completely fine - thanks for your work, looks clean and tidy!
I'll merge right now, thanks again! :)

jondot added a commit that referenced this pull request Jul 11, 2014

@jondot jondot merged commit cf86a68 into jondot:master Jul 11, 2014

@norman norman deleted the add_configuration_class branch Jul 11, 2014

@norman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2014

@jondot very sorry about this, but my PR neglected to include a delegation to @hash.fetch that's needed in the Sneakers runner. Sending another PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.