New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade plugin to kirby v3 syntax #3

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@afincato
Copy link

afincato commented Jan 23, 2019

hi there!

i've been using your plugin for several projects now, and the last days i was converting an early-stage website into kirby 3. your plugin was not working anymore due to kirby's internal API changes, so last night i managed to upgrade the few lines which were causing the error.

i tested it and it works fine! please give it a go as well and let me know if you're up to merge.

thanks for your work!
af

@jongacnik

This comment has been minimized.

Copy link
Owner

jongacnik commented Jan 23, 2019

Hey @afincato thanks for the tweaks. I'll take a look when I have a sec, when I get around to it I'll also want to update some readme contents and split off a k2 branch so as not to create confusion re: what kirby versions this supports.

@afincato

This comment has been minimized.

Copy link
Author

afincato commented Jan 24, 2019

yes!

regarding whether this plugin is still useful or not:

there is currently an ongoing discussion about it, and while some have a working example, i think it might be still useful to have spad automating at once the work one would need to do by manually setting up kirby's Content Representation templates (imho).

up to help out with the upgrade if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment