Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Viewer button > Log File is missing many log entries #436

Closed
solo-1234 opened this issue Jan 6, 2023 · 7 comments · Fixed by #465
Closed

Open Viewer button > Log File is missing many log entries #436

solo-1234 opened this issue Jan 6, 2023 · 7 comments · Fixed by #465
Assignees
@jongpie
Labels
Layer: Log Management Items related to the custom objects & Logger Console app Type: Bug Something isn't working
Milestone
Version v4.10.0 -...

Comments

@solo-1234
Copy link

On logs with many entries, clicking Open Viewer > Log File does not display all of them. For example, I have a log with 600+ entries which only shows 27 of them in the viewer.
@jongpie jongpie added the Type: Bug Something isn't working label Jan 9, 2023
@jongpie
Copy link
Owner

jongpie commented Jan 9, 2023

Thanks @solo-1234! I'm hoping that this is a fairly easy bugfix, I'll do some more analysis on it later this week.

@jongpie jongpie added the Layer: Log Management Items related to the custom objects & Logger Console app label Jan 9, 2023
@jongpie jongpie self-assigned this Jan 9, 2023
@solo-1234
Copy link
Author

Hi, just wondering if you got a chance to look at this. Thanks!

@jongpie
Copy link
Owner

jongpie commented Mar 20, 2023

Hey @solo-1234! Apologies, I haven't had much time to look at this one yet - but I'm actively working on v4.10.0, and I might be able to include this bugfix in that release. I'll spend some time working on this issue later this week - if it turns out to be a simple fix, I'll include it in v4.10.0.

@jamessimone
Copy link
Collaborator

Nice work on this one! It was great to pair on the solution.

@jongpie
Copy link
Owner

jongpie commented Mar 25, 2023

Thanks again for the help, glad to know I wasn't missing an obvious explanation for this one 😅 I'm hoping to push the commit for this later today (just need to finish some unit tests)

jongpie added a commit that referenced this issue Mar 26, 2023
@jongpie
Worked with @jamessimone to fix #436 - instead of returning a Log__c …
8f7a9f9 
…record with nested List<LogEntry__c>, LogViewerController now returns a LogDTO class, and Log__c and LogEntry__c records are queried separately

This means 2 queries are now used instead of 1, but this will avoid the limit of 200 child records per parent record, and circumvents the apparent platform bug that was preventing all LogEntry__c records from being returned (even when there were fewer than 200 records)
@jongpie jongpie mentioned this issue Mar 31, 2023
Merged
jongpie added a commit that referenced this issue Apr 5, 2023
@jongpie @jamessimone
Spring '23 release (API v57.0) - v4.10.0 (#465)
c9c4b5d 
* Bumped all metadata to API v57.0 (Summer '23 release)

* Added logging methods for Database.LeadConvertResult class (#471)

* Fixed #436 - instead of returning a Log__c record with nested List<LogEntry__c>, LogViewerController now returns a LogDTO class, and Log__c and LogEntry__c records are queried separately. This means 2 queries are now used instead of 1, but this will avoid the limit of 200 child records per parent record, and circumvents the apparent platform bug that was preventing all LogEntry__c records from being returned (even when there were fewer than 200 records)

* Small scope creep: added a lightning-spinner to logViewer that's displayed on load

* Fixed #469 by using @YodaDaCoda's suggestion to filter on the username (instead of name) when querying the autoproc user

* Moved the private constant LogEntryEventBuilder.ORGANIZATION_API_VERSION to Logger.ORGANIZATION_API_VERSION so Logger can dynamically include the API version for REST callouts

* Finally removed the last future method in the codebase (used to call the Salesforce Status API), and replaced it with a private queueable class

* Combined a few test methods in Logger_Tests

* Updated sfdx-cli

* Added sfdx commands to README.md for installing packages

* Updated some package.json scripts & sections in build.yml to use the new sfdx syntax for assigning permission sets

* Regenerated apex docs (there were a couple of pages that were out of date)

* Added a PMD rule exclusion for `EagerlyLoadedDescribeSObjectResult` until some npm dependencies & scripts have been upgraded

---------

Co-authored-by: James Simone <16430727+jamessimone@users.noreply.github.com>
@jongpie
Copy link
Owner

jongpie commented Apr 5, 2023

@solo-1234 it's finally fixed! I've just released the bugfix as part of the new version, v4.10.0 🥳

@solo-1234
Copy link
Author

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongpie jongpie

Labels
Layer: Log Management Items related to the custom objects & Logger Console app Type: Bug Something isn't working
Projects
None yet
Milestone
Version v4.10.0 - Spring '23 Release
Development

Successfully merging a pull request may close this issue.

Spring '23 release (API v57.0) - v4.10.0 jongpie/NebulaLogger
3 participants
@jongpie @jamessimone @solo-1234