Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LoggerEmailSender send all Database.Error fields #591

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

alanjaouen
Copy link
Contributor

resolve #590

@Damecek
Copy link
Sponsor

Damecek commented Dec 12, 2023

This is great, just received a bunch of such messages and was clueless. This will be very handy. Good job.

@Damecek
Copy link
Sponsor

Damecek commented Jan 2, 2024

@jongpie happy new year, could you please check out this PR? It would really help to clarify what exactly is the root cause of errors.

@jongpie jongpie added Type: Enhancement New feature or request Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine labels Jan 18, 2024
@jongpie
Copy link
Owner

jongpie commented Jan 18, 2024

@alanjaouen thanks so much for working on this, and apologies for the late response (same to you @Damecek)! I haven't been able to work on open source projects for the last few months, but I am back & working on catching up on this repo, starting with this PR.

Your changes look great to me - I think the inclusion of the error fields in the email will help a lot with troubleshooting bugs. I've also added a few extra asserts in a test class to validate that the error fields are included in the emails. I'll merge & release these changes later today!

@jongpie jongpie merged commit b24d1f5 into jongpie:main Jan 18, 2024
7 of 8 checks passed
@jongpie
Copy link
Owner

jongpie commented Jan 18, 2024

@alanjaouen and @Damecek this has now officially been released as v4.12.1! 🎉🥳💃 If you have any more feedback on how to improve the error emails, please let me know.

Thanks again @alanjaouen for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give more information about error in Error Notification mails
3 participants