Idle builder #202
Merged
Idle builder #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
jonhoo
requested changes
May 25, 2021
Owner
jonhoo
left a comment
jonhoo
left a comment
There was a problem hiding this comment.
Nice! I think it makes complete sense to make keep-alive the default, and I think it's fine to require SetReadTimeout 👍
Also kill timed_wait because it is only used in one place.
Contributor
Author
|
I think we are good to go on this one? |
jonhoo
approved these changes
May 27, 2021
Owner
jonhoo
left a comment
jonhoo
left a comment
There was a problem hiding this comment.
Excellent, thanks!
Separately, we really need to figure out what causes that CI failure all the time. Maybe it's time to drop the FreeBSD compile check altogether..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #191 .
Also includes the changes in #201 for convenience.
Note that this change effectively requires that the underlying transport implements the
SetReadTimeouttrait fromextensions::idle. I am not sure if this is a problem or not. If so, I can add the oldwait_while()back with a different name (wait_notimeout_while()?) to restore the functionality. I opted to remove it because the oldwait_keepalive_whilefunction was already broken for non-SetReadTimeouttransports, and it was the recommended way to do it. I am unsure if the extra API is worth it since implementingSetReadTimeoutis so trivial. Happy to get feedback on this.Note that this also makes
keepalivethe default, since it is the recommended way to do it. An opt-out function is provided (no_keepalive()) for users who do not want this. I figured that the recommended path should also be the default.This change is