Consider removing `#req` #11

jonleighton opened this Issue May 7, 2012 · 0 comments


None yet

1 participant


This seems like a bad abstraction in hindsight and obscure the intent of the tests.

@jonleighton jonleighton added a commit that closed this issue Aug 12, 2012
@jonleighton Remove the #req helper method
I think this was a bad idea. It looks kinda weird and obscures the
intent. Consider:

req id: 4


subject.params = { id: 4 }

The latter is clearly more verbose, but it's much more explicit about
what's being done, and makes it obvious that we are operating on the
object under test.

Closes #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment