From d50d23ec48f9dbe0b396e0c86ce394653e98c343 Mon Sep 17 00:00:00 2001 From: Mike Jolley Date: Mon, 22 Nov 2021 12:09:00 +0000 Subject: [PATCH] Fix manual entry within Quantity Inputs (#5197) * Use Number.isNaN to cast strings * Avoid changing type function --- assets/js/base/components/quantity-selector/index.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/assets/js/base/components/quantity-selector/index.tsx b/assets/js/base/components/quantity-selector/index.tsx index f27da359ec4..91e195a68bf 100644 --- a/assets/js/base/components/quantity-selector/index.tsx +++ b/assets/js/base/components/quantity-selector/index.tsx @@ -6,7 +6,6 @@ import { speak } from '@wordpress/a11y'; import classNames from 'classnames'; import { useCallback } from '@wordpress/element'; import { DOWN, UP } from '@wordpress/keycodes'; -import { isNumber } from '@woocommerce/types'; /** * Internal dependencies @@ -84,7 +83,8 @@ const QuantitySelector = ( { onKeyDown={ quantityInputOnKeyDown } onChange={ ( event ) => { let value = - ! isNumber( event.target.value ) || ! event.target.value + Number.isNaN( event.target.value ) || + ! event.target.value ? 0 : parseInt( event.target.value, 10 ); if ( hasMaximum ) {