forked from dotnet/java-interop
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Java.Interop.Export] Use JniEnvironment in marshal methods.
As noted in commit 2f9fece, Java.Interop.Export.ExportedMemberBuilder doesn't need to use JniEnvironment within it's generated code, as JniType.RegisterNativeMethods() automagically wraps delegates with the required JniEnvironment usage code. Thus, ExportedMemberBuilder doesn't *need* to emit JniEnvironment use RIGHT NOW. The question is rather regarding the future: one of the performance issues that needs investigation on Xamarin.Android is to improve support for AOT, so that startup overhead can be reduced/minimized by pre-JITing as much as possible via AOT. The problem with providing AOT support is that Xamarin.Android -- just like Java.Interop (unsurprisingly) -- ALSO automagically wraps all methods registered with the JVM with System.Reflection.Emit-generated code at runtime. It is thus not possible to AOT *everything*. *Lots* of things can be AOT'd, just not everything, and this is something that we would like to address, meaning all required sources of runtime code generation need to be removable. With that in mind, long-term we don't want ExportedMemberBuilder to rely on JniType.RegisterNativeMethods() behavior. (In fact, we'd want to REMOVE the currently required wrapping behavior from JniType.RegisterNativeMethods()!) Instead, long-term it would be "interesting" if we could use ExportedMemberBuilder to process assemblies, generate the JNI method marshaling code for ~everything, store that into a NEW assembly (as part of the build process), and AOT the marshaling assembly! How cool would that be? :-D But to even get there, we need the marshal code to be self-contained, and not rely upon runtime code generation semantics from "elsewhere".
- Loading branch information
Showing
2 changed files
with
150 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters