From e048ce532b00551f464941323898ef918cf54f23 Mon Sep 17 00:00:00 2001 From: Black-Hole <158099591@qq.com> Date: Tue, 26 Sep 2017 23:11:29 +0800 Subject: [PATCH 1/3] Update index.js The first parameter should be judged --- index.js | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/index.js b/index.js index 90f2807..86a0337 100644 --- a/index.js +++ b/index.js @@ -8,8 +8,10 @@ 'use strict'; module.exports = function diff(arr/*, arrays*/) { - var len = arguments.length; - var idx = 0; + if(!Array.isArray(arr)) return arr; + + var len = arguments.length, + ldx = 0; while (++idx < len) { arr = diffArray(arr, arguments[idx]); } @@ -20,11 +22,11 @@ function diffArray(one, two) { if (!Array.isArray(two)) { return one.slice(); } - - var tlen = two.length - var olen = one.length; - var idx = -1; - var arr = []; + + var olen = one.length, + tlen = two.length, + idx = -1, + arr = []; while (++idx < olen) { var ele = one[idx]; From 36af3b257b7a917984b231ab50092416f907fd1a Mon Sep 17 00:00:00 2001 From: Black-Hole <158099591@qq.com> Date: Wed, 27 Sep 2017 01:33:53 +0800 Subject: [PATCH 2/3] Update index.js revert this and use the same formatting as the rest of the code. --- index.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/index.js b/index.js index 86a0337..5959884 100644 --- a/index.js +++ b/index.js @@ -11,7 +11,7 @@ module.exports = function diff(arr/*, arrays*/) { if(!Array.isArray(arr)) return arr; var len = arguments.length, - ldx = 0; + var ldx = 0; while (++idx < len) { arr = diffArray(arr, arguments[idx]); } @@ -23,10 +23,10 @@ function diffArray(one, two) { return one.slice(); } - var olen = one.length, - tlen = two.length, - idx = -1, - arr = []; + var olen = one.length; + var tlen = two.length; + var idx = -1; + var arr = []; while (++idx < olen) { var ele = one[idx]; From ddb57eb58deb388cc34bc95a3c1ab34f1c9286a0 Mon Sep 17 00:00:00 2001 From: Brian Woodward Date: Wed, 24 Oct 2018 08:32:31 +0800 Subject: [PATCH 3/3] Update index.js Co-Authored-By: BlackHole1 <158blackhole@gmail.com> --- index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.js b/index.js index 5959884..ddd58cf 100644 --- a/index.js +++ b/index.js @@ -10,7 +10,7 @@ module.exports = function diff(arr/*, arrays*/) { if(!Array.isArray(arr)) return arr; - var len = arguments.length, + var len = arguments.length; var ldx = 0; while (++idx < len) { arr = diffArray(arr, arguments[idx]);