Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly adds spaces after links (and other inline markup) at the end of sentences. #2

Closed
arlobelshee opened this issue Feb 27, 2015 · 4 comments

Comments

@arlobelshee
Copy link

This transforms the original text:

A simple example.

to:

A simple example .

Which changes the rendering from:

A simple example.

to:

A simple example .

The problem is the last replace expression in your ocd function. However, I am not sure what problem that is working around. I think you need to find and fix the underlying problem so that you don't need the workaround.

Until then, I've simply disabled prettification. I would much rather have messy and overly-long HTML that renders correctly.

@jonschlinkert
Copy link
Owner

thanks for creating the issue. I'll look into it.

I would much rather have messy and overly-long HTML that renders correctly.

well, I would hope so lol. we all would. I never use prettification in production code, I just prefer looking at structured HTML during dev. not to digress, the code in the project is old, and I would do it differently today.

@george-norris-salesforce

Any update on this?

@jonschlinkert
Copy link
Owner

hi @george-norris-salesforce, thanks for the ping. I'll pull it down now

@jonschlinkert
Copy link
Owner

@george-norris-salesforce I just pushed up 2.0. This is basically a thin wrapper around js-beautify to provide sensible defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants