Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #18 : Exclude not working #19

Merged
merged 2 commits into from Oct 23, 2018
Merged

Conversation

ywpark1
Copy link
Contributor

@ywpark1 ywpark1 commented Oct 4, 2018

The issue is that if exclude option has right square bracket, the regular expression pattern breaks, and it does not exclude any characters user input.

I added few lines of code to handle right square bracket. I also added two test cases when exclude option has right square bracket character.

Let me know if I need to adjust the code.
Thanks.

@ywpark1
Copy link
Contributor Author

ywpark1 commented Oct 12, 2018

@doowb Let me know if there are other issues based on my PR!

@doowb
Copy link
Collaborator

doowb commented Oct 23, 2018

@ywpark1 thanks for the PR! LGTM. Sorry for the delay.

@doowb doowb merged commit 8e78da8 into jonschlinkert:master Oct 23, 2018
@doowb doowb mentioned this pull request Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants