Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links: rework URL unescaping #97

Closed
4 tasks done
puzrin opened this issue Nov 6, 2014 · 0 comments
Closed
4 tasks done

Links: rework URL unescaping #97

puzrin opened this issue Nov 6, 2014 · 0 comments

Comments

@puzrin
Copy link
Contributor

puzrin commented Nov 6, 2014

Current links unescaping should be reworked:

  • Doing it in renderer is not correct. There should be url encoding only.
  • Linkifier links can be unescaped twice. Make sure it's in sync with other (links, images, autolinks)
  • Algorythm, is dirty http://talk.commonmark.org/t/unclarities-wrt-urlescaping/782 (had no time to dio it better
  • Review validation fn to make sure it's enougth.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants