diff --git a/src/main/java/com/google/devtools/build/lib/analysis/LicensesProviderImpl.java b/src/main/java/com/google/devtools/build/lib/analysis/LicensesProviderImpl.java index 98d087632ebe48..6e00fc278606c7 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/LicensesProviderImpl.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/LicensesProviderImpl.java @@ -68,7 +68,7 @@ public static LicensesProvider of(RuleContext ruleContext) { ListMultimap configuredMap = ruleContext.getConfiguredTargetMap(); - if (rule.getRuleClassObject().isBazelLicense()) { + if (rule.getRuleClassObject().isPackageMetadataRule()) { // Don't crawl a new-style license, it's effectively a leaf. // The representation of the new-style rule is unfortunately hardcoded here, // but this is code in the old-style licensing path that will ultimately be removed. diff --git a/src/main/java/com/google/devtools/build/lib/packages/DefaultPackageArguments.java b/src/main/java/com/google/devtools/build/lib/packages/DefaultPackageArguments.java index ae89e98788d517..a32f000ce70f26 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/DefaultPackageArguments.java +++ b/src/main/java/com/google/devtools/build/lib/packages/DefaultPackageArguments.java @@ -17,6 +17,7 @@ import com.google.common.collect.ImmutableList; import com.google.devtools.build.lib.cmdline.Label; import com.google.devtools.build.lib.packages.License.DistributionType; +import com.google.devtools.build.lib.server.FailureDetails.PackageLoading.Code; import java.util.List; import java.util.Set; import net.starlark.java.eval.EvalException; @@ -30,15 +31,16 @@ private DefaultPackageArguments() {} /** Returns the default set of {@link PackageArgument}s. */ static ImmutableList> get() { return ImmutableList.of( - new DefaultDeprecation(), - new DefaultDistribs(), - new DefaultApplicableLicenses(), - new DefaultLicenses(), - new DefaultTestOnly(), - new DefaultVisibility(), - new Features(), - new DefaultCompatibleWith(), - new DefaultRestrictedTo()); + new DefaultDeprecation(), + new DefaultDistribs(), + new DefaultApplicableLicenses(), + new DefaultPackageMetadata(), + new DefaultLicenses(), + new DefaultTestOnly(), + new DefaultVisibility(), + new Features(), + new DefaultCompatibleWith(), + new DefaultRestrictedTo()); } private static class DefaultVisibility extends PackageArgument> { @@ -95,17 +97,48 @@ protected void process(Package.Builder pkgBuilder, Location location, * specified. */ private static class DefaultApplicableLicenses extends PackageArgument> { - private static final String DEFAULT_APPLICABLE_LICENSES_ATTRIBUTE = - "default_applicable_licenses"; - private DefaultApplicableLicenses() { - super(DEFAULT_APPLICABLE_LICENSES_ATTRIBUTE, BuildType.LABEL_LIST); + super("default_applicable_licenses", BuildType.LABEL_LIST); + } + + @Override + protected void process(Package.Builder pkgBuilder, Location location, List