Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Article submenu generate wrong URL #58

Closed
DjBuRnOuT opened this issue Jul 3, 2019 · 10 comments
Closed

Single Article submenu generate wrong URL #58

DjBuRnOuT opened this issue Jul 3, 2019 · 10 comments
Assignees

Comments

@DjBuRnOuT
Copy link

@DjBuRnOuT DjBuRnOuT commented Jul 3, 2019

Hi,
I installed Astroid 2.2.2 yesterday but I rolled back to 2.2.1 because all of my submenus generated wrong URLs.. I know it's not that clear but let me in explain it in details:

I have a menu which is a menu header linking to a single article, which works fine.
I have multiple submenus liniking to external URL with the above menu header as parent but the link generated by these is wrong. There's 3 times the current URL + the link from the menu, ex:
https://mywebsite.com/currentpagehttps://mywebsite.com/currentpagehttps://mywebsite.com/currentpagehttps://myexternallink.com

This behavior doesn't happen on another theme nor with the 2.2.1 version of your framework.
I rollbacked to 2.2.1 for the moment but I wanted to report it to you for future updates.

I run on a dedicated linux machine running apache with URL Rewriting enabled but the problem happens even when I disable the SEO on joomla. I use the latest version of joomla too, everything is up to date and I don't use any extensions besides your framework.

@chetanmadaan

This comment has been minimized.

Copy link
Member

@chetanmadaan chetanmadaan commented Jul 4, 2019

This is related to a one page integration we added. Can you provide a link to your site. It'd be helpful to see the problem and apply a fix.

This is likely to happen if you links have # in them.

@chetanmadaan

This comment has been minimized.

Copy link
Member

@chetanmadaan chetanmadaan commented Jul 4, 2019

@DjBuRnOuT

This comment has been minimized.

Copy link
Author

@DjBuRnOuT DjBuRnOuT commented Jul 4, 2019

I could do it but it breaks my links for my website so I just reuploaded the link.php of the 2.2.2 version and the problem is occuring, something must be way different in the way you handle links. I have basic knowledge of php but I wouldn't be able to correct it by myself. you can see the attached screen to see what's happening.

@chetanmadaan

This comment has been minimized.

Copy link
Member

@chetanmadaan chetanmadaan commented Jul 4, 2019

Hello,

I tried it on my end and couldn't actually reproduce it. I tried the following links in the external link type menu item.

http://localhost/astroid221/#justhashlink
#justhashlink
https://www.google.com/#justhashlink
http://localhost/astroid221/#justhashlink?watch=Icn
#justhashlink?watch=Icn
https://www.google.com/#justhashlink?watch=Icn

All of these seems to work just fine.

Can you provide what you are inputting in the backend and what the actual link is being created in the frontend?

@DjBuRnOuT

This comment has been minimized.

Copy link
Author

@DjBuRnOuT DjBuRnOuT commented Jul 4, 2019

Here's how my menu is set up, My menu header is actually a link to a single article.

@chetanmadaan

This comment has been minimized.

Copy link
Member

@chetanmadaan chetanmadaan commented Jul 4, 2019

Thanks. This is fine. What's the actual URL of the LCN menu item? May be that has something to do with it.

@DjBuRnOuT

This comment has been minimized.

Copy link
Author

@DjBuRnOuT DjBuRnOuT commented Jul 4, 2019

It's https://xxxxxxxxxx/streams?watch=lcn . The header itself is an URL rewrite of a single article and it's https://xxxxxxxxxx/streams BUT even if I set the URL to something else like https://xxxxxxxxxx or even https://google.ca on the submenus, I get the current URL repeated 3 times before the real link like I've shown above.

@chetanmadaan

This comment has been minimized.

Copy link
Member

@chetanmadaan chetanmadaan commented Jul 5, 2019

@DjBuRnOuT try the Dev version after the commit on this issue and see if that works.
#60

You can download the dev version from the url https://github.com/joomdev/Astroid-Framework/archive/dev.zip

@astrorawson

This comment has been minimized.

Copy link

@astrorawson astrorawson commented Jul 6, 2019

I have the very same issue. It started after upgrading Astroid to 2.2.2.
Every external URL changed from https://myexternallink.com to https://mywebsite.com/currenpagehttps://mywebsite.com/currenpagehttps://mywebsite.com/currenpagehttps://myexternallink.com

Is there any solution or patch for this, or should I rollback to Astroid 2.2.1 ?

@astrorawson

This comment has been minimized.

Copy link

@astrorawson astrorawson commented Jul 6, 2019

Installed the dev version and the issue was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.