Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag JD Builder Pro where required #15

Closed
shoulders opened this issue Nov 10, 2019 · 5 comments
Closed

Tag JD Builder Pro where required #15

shoulders opened this issue Nov 10, 2019 · 5 comments
Assignees
Labels

Comments

@shoulders
Copy link

@shoulders shoulders commented Nov 10, 2019

  • Within the component you should make a change to show it is pro

image

  • Maybe on the installer splash screen so the user know he has installed the pro verion and not the free one again.
  • tag the pro in the following list
    image
@chetanmadaan

This comment has been minimized.

Copy link
Member

@chetanmadaan chetanmadaan commented Nov 11, 2019

Agreed, The footer and the system plugin should both change name.

@chandanndeep & @hiteshaggarwal to make the fix.

@chandanndeep

This comment has been minimized.

Copy link
Member

@chandanndeep chandanndeep commented Jan 1, 2020

@shoulders

We have added the tag in v1.4.0.

image
image

@shoulders

This comment has been minimized.

Copy link
Author

@shoulders shoulders commented Jan 19, 2020

@chandanndeep Does this issue need closing? it seems complete.

@chandanndeep

This comment has been minimized.

Copy link
Member

@chandanndeep chandanndeep commented Jan 20, 2020

@shoulders
Yes, it is complete

@chandanndeep

This comment has been minimized.

Copy link
Member

@chandanndeep chandanndeep commented Jan 20, 2020

@shoulders
Thanks for reporting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.