postgresql - error on pkg installation #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Steps to reproduce the issue try to install on postgresql #### Expected result it install #### Actual result don't install #### System information (as much as possible) Weblinks 3.4.1 Release Candidate 2 PostgreSQL 9.3.5 Joomla 3.4.4-dev #### Additional comments without the setting give an invalid timestamp for the category table
| @@ -42,6 +42,7 @@ public function install($parent) | |||
| $category->params = '{"category_layout":"","image":""}'; | |||
| $category->metadata = '{"author":"","robots":""}'; | |||
| $category->language = '*'; | |||
| $category->checked_out_time = JFactory::getDbo()->quote(JFactory::getDbo()->getNullDate()); | |||
There was a problem hiding this comment.
This shouldn't need to be quoted here, JTable should be managing that when the record is inserted.
@mbabker, removed.
mbabker
added a commit
that referenced
this pull request
Jul 14, 2015
postgresql - error on pkg installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue
try to install on postgresql
Expected result
it install
Actual result
don't install
System information
Weblinks 3.4.1 Release Candidate 2
PostgreSQL 9.3.5
Joomla 3.4.4-dev
Additional comments
without the setting give an invalid timestamp for the category table