Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Two "images" tabs in Web links #91

Merged
merged 1 commit into from Sep 10, 2015

Conversation

Projects
None yet
3 participants
@zero-24
Copy link
Contributor

zero-24 commented Sep 10, 2015

Hi,
As an user said today in french Joomla! forum, on Joomla! 3.4.4, web links have two "images" tabs, so adding an image is not possible. I tested and confirm. You can save, but images are not saved: if you edit, all fields remains empty.
weblinks
Thanks for your help!
Robert


Patch and confirm the fix by @infograf768 fixes the problem.

@committer please mention @infograf768 thanks.

@zero-24 zero-24 added the bug label Sep 10, 2015

@zero-24 zero-24 added this to the 3.4.2 milestone Sep 10, 2015

@zero-24

This comment has been minimized.

Copy link
Contributor Author

zero-24 commented Sep 10, 2015

this pull is successful tested by @fontanil here: #89 (comment)

@infograf768

This comment has been minimized.

Copy link
Contributor

infograf768 commented Sep 10, 2015

Tested OK for me too.

@Kubik-Rubik Kubik-Rubik added the RTC label Sep 10, 2015

Kubik-Rubik added a commit that referenced this pull request Sep 10, 2015

Merge pull request #91 from joomla-extensions/zero-24-patch-1
Fix: Two "images" tabs in Web links

@Kubik-Rubik Kubik-Rubik merged commit 88d2517 into master Sep 10, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kubik-Rubik

This comment has been minimized.

Copy link
Contributor

Kubik-Rubik commented Sep 10, 2015

Thank you @zero-24! Merged.

@zero-24 zero-24 deleted the zero-24-patch-1 branch Sep 10, 2015

@zero-24

This comment has been minimized.

Copy link
Contributor Author

zero-24 commented Sep 10, 2015

@Kubik-Rubik Code is by @infograf768 i have just send the PR ;)

@zero-24 zero-24 removed the RTC label Sep 10, 2015

@infograf768

This comment has been minimized.

Copy link
Contributor

infograf768 commented Sep 10, 2015

No worry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.