From 09545910843aa80e6818f3ab1868b4ca96fbc577 Mon Sep 17 00:00:00 2001 From: javier gomez Date: Tue, 3 May 2016 16:13:43 +0200 Subject: [PATCH 1/3] Update modulePosition method closes #109 --- src/JoomlaBrowser.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/JoomlaBrowser.php b/src/JoomlaBrowser.php index 719d153..1dad486 100644 --- a/src/JoomlaBrowser.php +++ b/src/JoomlaBrowser.php @@ -672,7 +672,7 @@ public function setModulePosition($module, $position = 'position-7') $I->amOnPage('administrator/index.php?option=com_modules'); $I->searchForItem($module); $I->click(['link' => $module]); - $I->waitForText($module, 30, ['css' => 'H3']); + $I->waitForText("Modules: $module", 30, ['css' => 'h1.page-title']); $I->selectOptionInChosen('Position', $position); $I->click(['xpath' => "//div[@id='toolbar-apply']/button"]); $I->waitForText('Module successfully saved',30,['id' => 'system-message-container']); From 79fc085999e1c23be7f07dd694c11f63f4b779b5 Mon Sep 17 00:00:00 2001 From: javier gomez Date: Tue, 3 May 2016 16:29:23 +0200 Subject: [PATCH 2/3] Ensure that we are in the first tab before changing position --- src/JoomlaBrowser.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/JoomlaBrowser.php b/src/JoomlaBrowser.php index 1dad486..da1298c 100644 --- a/src/JoomlaBrowser.php +++ b/src/JoomlaBrowser.php @@ -673,6 +673,7 @@ public function setModulePosition($module, $position = 'position-7') $I->searchForItem($module); $I->click(['link' => $module]); $I->waitForText("Modules: $module", 30, ['css' => 'h1.page-title']); + $I->click(['link' => 'Module']); $I->selectOptionInChosen('Position', $position); $I->click(['xpath' => "//div[@id='toolbar-apply']/button"]); $I->waitForText('Module successfully saved',30,['id' => 'system-message-container']); From be95abd714cbe64d7cb580a45f77bc30382d2756 Mon Sep 17 00:00:00 2001 From: javier gomez Date: Tue, 3 May 2016 16:32:21 +0200 Subject: [PATCH 3/3] Wait until first tab is loaded --- src/JoomlaBrowser.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/JoomlaBrowser.php b/src/JoomlaBrowser.php index da1298c..d13cc85 100644 --- a/src/JoomlaBrowser.php +++ b/src/JoomlaBrowser.php @@ -674,6 +674,7 @@ public function setModulePosition($module, $position = 'position-7') $I->click(['link' => $module]); $I->waitForText("Modules: $module", 30, ['css' => 'h1.page-title']); $I->click(['link' => 'Module']); + $I->waitForText($module, 30, ['css' => 'h3']); $I->selectOptionInChosen('Position', $position); $I->click(['xpath' => "//div[@id='toolbar-apply']/button"]); $I->waitForText('Module successfully saved',30,['id' => 'system-message-container']);