Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JoomlaBrowser.php #216

Merged
merged 2 commits into from Jun 25, 2021
Merged

Update JoomlaBrowser.php #216

merged 2 commits into from Jun 25, 2021

Conversation

stell
Copy link

@stell stell commented Jun 24, 2021

Select was not working because of space in span tag. This was successfully tested.

@stell
Update JoomlaBrowser.php
4f9baae 
Select was not working because of space in span tag. This was successfully tested.
@HLeithner
Copy link
Member

HLeithner commented Jun 25, 2021 •
edited

Thanks for you contribution!

I will sort the composer errors and merge it afterwards.

note: j4 uses data-bs-target attribute

@HLeithner HLeithner merged commit bd782d1 into joomla-projects:develop Jun 25, 2021
@HLeithner
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stell @HLeithner