Change code style #17

Merged
merged 1 commit into from Feb 24, 2013

Conversation

Projects
None yet
5 participants
@elkuku
Member

elkuku commented Feb 4, 2013

This is a proposal to change the current coding style.

The current coding standard enforces an underscore "prefixing" private class member variables.

I believe that this is a relic from bad old pre-PHP 5 times when protected and private members and methods had been decorated this way to provide some sort of "visual aid" to the developer.

Currently a checkstyle error is thrown when a private class member is declared without an underscore.
This proposes to change this behavior to emit a warning if a private member has an underscore.

This will obviously raise the warnings emitted by the style checker on the current code base.
The next step would be to change those offending names, which should be save to do, and maybe change the warning to error.

Change code style
Enforce no underscore prefixing private member vars.
@brunowego

This comment has been minimized.

Show comment Hide comment
@brunowego

brunowego Feb 4, 2013

👍

👍

@okonomiyaki3000

This comment has been minimized.

Show comment Hide comment
@okonomiyaki3000

okonomiyaki3000 Feb 4, 2013

Yay.

Yay.

@dongilbert

This comment has been minimized.

Show comment Hide comment
@dongilbert

dongilbert Feb 24, 2013

Contributor

👍

Contributor

dongilbert commented Feb 24, 2013

👍

eddieajau added a commit that referenced this pull request Feb 24, 2013

@eddieajau eddieajau merged commit 005a921 into joomla:master Feb 24, 2013

@elkuku elkuku deleted the elkuku:cs-private-members-no-underscore branch Feb 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment