Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix issue with InstantiateNewClassesSniff #2

Merged
merged 1 commit into from Jun 18, 2012

Conversation

Projects
None yet
2 participants
Contributor

pasamio commented Jun 18, 2012

The following line would trigger issues with the InstantiateNewClassesSniff:
$model = new JModelDatabase(new JRegistry, JFactory::getDbo());

This incorrectly finds the JFactory::getDbo() parenthesis and assumes they're there for the JRegistry call. This pull request adds the comma to the list of escape tokens to reset the call.

Fix issue with InstantiateNewClassesSniff
The following line would trigger issues with the InstantiateNewClassesSniff:
$model = new JModelDatabase(new JRegistry, JFactory::getDbo());

This incorrectly finds the JFactory::getDbo() parenthesis and assumes they're there for the JRegistry call. This pull request adds the comma to the list of escape tokens to reset the call.

LouisLandry added a commit that referenced this pull request Jun 18, 2012

Merge pull request #2 from pasamio/master
Fix issue with InstantiateNewClassesSniff

@LouisLandry LouisLandry merged commit 23a8018 into joomla:master Jun 18, 2012

nibra referenced this pull request in GreenCape/coding-standards Oct 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment