Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jedchecker rules migrated to PHPCS 3.x #246

Closed
wants to merge 54 commits into from

Conversation

@Texpaok
Copy link

commented Jun 21, 2019

Paladin and others added some commits Jul 14, 2017

Rough draft
Have not touched the tests, but the code executes and produces results.
(Hard to take the provided tests seriously when they require a version
of PHPUnit that’s long past end of support. I should tackle that next.)
Namespaced the unit tests
Now to get the classes to autoload
Typo cleanup
Fatfinger, fatfinger, make it go crash!
pull in phpcs bugfix
This will get the tests passing.

TODO: Once version 3.1 of phpcs rolls out change this line to  require
“^3.1”
Merge pull request #195 from pkware/phpcs3
Code Sniffer version 3
Update minimum PHP since PHPCS 3.x is PHP 5.4+
Update notes and other details in readme
Merge pull request #201 from photodude/patch-5
Update minimum PHP since PHPCS 3.x is PHP 5.4+
Add Squiz.WhiteSpace.MemberVarSpacing
As of PHPCS 3.1.0 we can use Squiz.WhiteSpace.MemberVarSpacing rather than a custom sniff with new property spacingBeforeFirst=0. One less custom sniff to maintain.
Delete MemberVarSpacingUnitTest.inc
no longer needed as the custom sniff has been removed.
Delete MemberVarSpacingUnitTest.inc.fixed
no longer needed as the custom sniff has been removed.
Delete MemberVarSpacingUnitTest.php
no longer needed as the custom sniff has been removed.
specify the PHP_CodeSniffer bootstrap file on the command line
needed for the PHP_CodeSniffer unit tests

photodude and others added some commits Oct 18, 2017

Merge pull request #207 from photodude/patch-5
switch to Squiz.WhiteSpace.MemberVarSpacing
Remove DisallowShortArraySyntax in version 3
Since version 3 of the code style is PHP5.4+ we do not need to exclude the use of short array syntax as we are not supporting PHP 5.3 with version 3.
In the future, we may enforce DisallowLongArraySyntax but for now version 3 should allow both.
Remove Short Array condition
Short array syntax is explicitly allowed for PHP5.4+ projects
Property was removed for controlling short array use
Short array is allowed for Version 3 with php 5.4+
Remove Generic.Arrays.DisallowShortArraySyntax
this exclude rule does not apply in version 3
Merge pull request #211 from photodude/patch-4
Remove DisallowShortArraySyntax in version 3
Fixes outdated command
`composer property-set minimum-stability "alpha"`

```
$ composer property-set minimum-stability "alpha"                                                             
                                                                                                                                                
  [Symfony\Component\Console\Exception\CommandNotFoundException]                                                                                
  Command "property-set" is not defined.                                                                                                        
                                                                                                                                                
                                           
```

`composer config minimum-stability "alpha"` did the job.
Merge pull request #233 from gruz/patch-2
Fixes outdated command
@mbabker

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

I'm not quite sure what you're trying to do with this pull request, but I'm closing it as invalid since it's proposing merging two branches on this repo. If you're trying to propose changes, those changes should be made and a proper pull request opened, not a ZIP file attached to a random item.

@mbabker mbabker closed this Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.