Remove Generic.PHP.ForbiddenFunctions sniff

[elkuku]

This removes the check for the deprecated functions delete() and sizeof().
Those checks are currently choking with namespaced classes with these names.

Like: https://github.com/joomla/jissues/blob/master/src/App/GitHub/Controller/Ajax/Labels/Delete.php#L19

Example Travis log: https://travis-ci.org/joomla/jissues/jobs/14662814

[mbabker]

Is this still an issue with the current release of PHPCS? https://github.com/squizlabs/PHP_CodeSniffer/blob/master/package.xml#L2232-L2265 - It looks like this was fixed in the 1.5.1 release.

[elkuku]

On our little project (where I discovered this) I get:

elkuku@kukubox640:~/repos/jissues$ phpcs -p --standard=build/phpcs/Joomla/ src/App/Text/Controller/
..E...


FILE: /home/elkuku/repos/jissues/src/App/Text/Controller/Article/Delete.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 20 | ERROR | The use of function delete() is forbidden; use unset() instead
--------------------------------------------------------------------------------

---

elkuku@kukubox640:~/repos/jissues$ phpcs --version
PHP_CodeSniffer version 1.5.1 (stable) by Squiz (http://www.squiz.net)

[mbabker]

Well, that answers that then.