Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change JOOMLA_VERSION and JOOMLA_SHA1 from ENV to ARG #22

Closed
dukeofgaming opened this issue Jun 25, 2017 · 1 comment
Closed

Change JOOMLA_VERSION and JOOMLA_SHA1 from ENV to ARG #22

dukeofgaming opened this issue Jun 25, 2017 · 1 comment

Comments

@dukeofgaming
Copy link

It would be nice to allow overriding these variables at build time in order to be able to install later versions not yet distributed officially.

@mbabker
Copy link
Contributor

mbabker commented Jul 4, 2017

Based on the repeatability guideline, I'm going to close this out as a won't fix.

Generally I'm good about updating the image on release day, but as of late I've had some hectic schedules that made this a bit more complicated than need be.

If there ever is a time where this falls out of sync with the main releases for more than a day or two, updating the images is as simple as running the update.php script here in the repo and submitting a PR. Then I can send the needed PR upstream to the official-images library to get that updated.

I've also got an open task to just automate this whole thing through our Jenkins CI server so part of the release pipeline would be to update this library and send the update PR upstream. It's just been low priority since this is about 90 seconds of work for me to update everything every month or two.

@mbabker mbabker closed this as completed Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants