Permalink
Browse files

# [#29225] Code quality in installation script. Thanks Dennis

  • Loading branch information...
1 parent 24f1159 commit 15f316f850c044a523a061adaa856c64336b0f34 @Denitz Denitz committed with infograf768 Sep 19, 2012
Showing with 18 additions and 7 deletions.
  1. +1 −0 installation/CHANGELOG
  2. +13 −7 installation/template/js/installation.js
  3. +4 −0 media/cms/css/bootstrap.css
View
@@ -32,6 +32,7 @@ $ -> Language fix or change
+$ Adding installation languages: bs-BA, hr-HR, lv-LV, mk-MK
# [#29223] *Sliders implementation prevents display of some Options in dropdowns (bootstrap). Thanks Yannick
# [#29232] Com_weblinks and com_newsfeeds loose "Status" filter state. Thanks Yannick
+ # [#29225] Code quality in installation script. Thanks Dennis
18-Sep-2012 Jean-Marie Simonet
# [#29091] *Language issues during installation: E-Mail always in English. Thanks Dennis
@@ -29,10 +29,11 @@ var Installation = new Class({
alert(Joomla.JText._('INSTL_PROCESS_BUSY', 'Process is in progress. Please wait...'));
return false;
}
-
+
var req = new Request.JSON({
- url: this.baseUrl + '?format=json',
+ url: this.baseUrl,
data: form,
+ format: 'json',
onRequest: function() {
this.spinner.show(true);
this.busy = true;
@@ -73,8 +74,9 @@ var Installation = new Class({
}
var req = new Request.JSON({
- url: this.baseUrl + '?format=json',
+ url: this.baseUrl,
data: form,
+ format: 'json',
onRequest: function() {
this.spinner.show(true);
this.busy = true;
@@ -152,8 +154,9 @@ var Installation = new Class({
var tr = document.id('install_'+task);
var req = new Request.JSON({
- url: this.baseUrl + '?task=setup.install_' + task + '&format=json',
+ url: this.baseUrl + '?task=setup.install_' + task,
data: form,
+ format: 'json',
onRequest: function() {
progress.setStyle('width',(progress.getStyle('width').toFloat()+step_width)+'%');
tr.addClass('active');
@@ -192,8 +195,9 @@ var Installation = new Class({
detectFtpRoot: function(el) {
el = document.id(el);
var req = new Request.JSON({
- url: this.baseUrl + '?task=setup.detectFtpRoot&format=json',
+ url: this.baseUrl + '?task=setup.detectFtpRoot',
data: document.id(el.form),
+ format: 'json',
onRequest: function() {
el.set('disabled', 'disabled');
},
@@ -224,8 +228,9 @@ var Installation = new Class({
// make the ajax call
el = document.id(el);
var req = new Request.JSON({
- url: this.baseUrl + '?task=setup.verifyFtpSettings&format=json',
+ url: this.baseUrl + '?task=setup.verifyFtpSettings',
data: document.id(el.form),
+ format: 'json',
onRequest: function() {
el.set('disabled', 'disabled'); },
onFailure: function(xhr) {
@@ -260,8 +265,9 @@ var Installation = new Class({
removeFolder: function(el) {
el = document.id(el);
var req = new Request.JSON({
- url: this.baseUrl + '?task=setup.removeFolder&format=json',
+ url: this.baseUrl + '?task=setup.removeFolder',
data: document.id(el.form),
+ format: 'json',
onRequest: function() {
el.set('disabled', 'disabled');
document.id('theDefaultError').setStyle('display','none');
@@ -0,0 +1,4 @@
+/* Fix for #29223: ref: http://stackoverflow.com/questions/10959068/twitter-bootstrap-accordion-and-button-dropdown-overflow-issue */
+.accordion-body.in:hover {
+ overflow:visible;
+}

0 comments on commit 15f316f

Please sign in to comment.