# [#32868] Trashed categories create a fatal error when creating URLs

to them, URLs to contact categories are wrong. Thanks Hannes Papenberg (Fix #2636)
joomla · Dec 4, 2013 · 5af3c90 · 5af3c90
1 parent b34f7e1
commit 5af3c90
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/components/com_contact/helpers/route.php b/components/com_contact/helpers/route.php
@@ -66,7 +66,7 @@ public static function getCategoryRoute($catid)
 			$category = JCategories::getInstance('Contact')->get($id);
 		}
 
-		if($id < 1)
+		if ($id < 1 || !($category instanceof JCategoryNode))
 		{
 			$link = '';
 		}
@@ -83,7 +83,7 @@ public static function getCategoryRoute($catid)
 
 			if ($item = self::_findItem($needles))
 			{
-				$link = 'index.php?Itemid='.$item;
+				$link .= '&Itemid='.$item;
 			}
 		}
 

diff --git a/components/com_newsfeeds/helpers/route.php b/components/com_newsfeeds/helpers/route.php
@@ -68,7 +68,7 @@ public static function getCategoryRoute($catid)
 			$category = JCategories::getInstance('Newsfeeds')->get($id);
 		}
 
-		if($id < 1)
+		if ($id < 1 || !($category instanceof JCategoryNode))
 		{
 			$link = '';
 		}

diff --git a/components/com_weblinks/helpers/route.php b/components/com_weblinks/helpers/route.php
@@ -86,7 +86,8 @@ public static function getCategoryRoute($catid)
 			$category = JCategories::getInstance('Weblinks')->get($id);
 		}
 
-		if ($id < 1) {
+		if ($id < 1 || !($category instanceof JCategoryNode))
+		{
 			$link = '';
 		}
 		else {

diff --git a/installation/CHANGELOG b/installation/CHANGELOG
@@ -26,6 +26,9 @@ $ -> Language fix or change
 - -> Removed
 ! -> Note
 
+04-Dec-2013 Jean-Marie Simonet
+ # [#32868] Trashed categories create a fatal error when creating URLs to them, URLs to contact categories are wrong. Thanks Hannes Papenberg
+
 26-Nov-2013 Jean-Marie Simonet
  # [#32812] *Wrong JText causes double string use