From 6d714c53134ff709955eb1c53c289dd2a0b4cdcf Mon Sep 17 00:00:00 2001
From: Benjamin Trenkle <bembelimen@users.noreply.github.com>
Date: Sun, 8 May 2016 14:07:10 +0200
Subject: [PATCH] [Regression] Readded stuff from #10190 (#10281)

* Deactivate batch for "all items" again

* Renamed apublished => a.published

* Add new line at eof

* Update default_batch_footer.php

Same changes to the batchfooter.
---
 administrator/components/com_menus/models/items.php    |  2 +-
 .../com_menus/views/items/tmpl/default_batch_body.php  | 10 ++++++++--
 .../views/items/tmpl/default_batch_footer.php          |  4 ++--
 3 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/administrator/components/com_menus/models/items.php b/administrator/components/com_menus/models/items.php
index 0457c32febb56..96daea00de3fe 100644
--- a/administrator/components/com_menus/models/items.php
+++ b/administrator/components/com_menus/models/items.php
@@ -194,7 +194,7 @@ protected function getListQuery()
 					),
 					array(
 						null, null, null, null, null, null, null, null, null,
-						null, 'apublished', null, null, null, null,
+						null, 'a.published', null, null, null, null,
 						null, null, null, null, null, null, null, null, null
 					)
 				)
diff --git a/administrator/components/com_menus/views/items/tmpl/default_batch_body.php b/administrator/components/com_menus/views/items/tmpl/default_batch_body.php
index 49fc124a987ce..5e78225003919 100644
--- a/administrator/components/com_menus/views/items/tmpl/default_batch_body.php
+++ b/administrator/components/com_menus/views/items/tmpl/default_batch_body.php
@@ -13,8 +13,9 @@
 	JHtml::_('select.option', 'm', JText::_('JLIB_HTML_BATCH_MOVE'))
 );
 $published = $this->state->get('filter.published');
+$menuType = JFactory::getApplication()->getUserState('com_menus.items.menutype');
 ?>
-
+<?php if (strlen($menuType) && $menuType != '*') : ?>
 <div class="row-fluid">
 	<div class="control-group span6">
 		<div class="controls">
@@ -45,4 +46,9 @@
 			<?php echo JHtml::_('select.radiolist', $options, 'batch[move_copy]', '', 'value', 'text', 'm'); ?>
 		</div>
 	<?php endif; ?>
-</div>
\ No newline at end of file
+</div>
+<?php else : ?>
+<div class="row-fluid">
+	<p><?php echo JText::_('COM_MENUS_SELECT_MENU_FIRST') ?></p>
+</div>
+<?php endif; ?>
diff --git a/administrator/components/com_menus/views/items/tmpl/default_batch_footer.php b/administrator/components/com_menus/views/items/tmpl/default_batch_footer.php
index 8c7355e555907..0ee724dbbaca7 100644
--- a/administrator/components/com_menus/views/items/tmpl/default_batch_footer.php
+++ b/administrator/components/com_menus/views/items/tmpl/default_batch_footer.php
@@ -8,12 +8,12 @@
  */
 defined('_JEXEC') or die;
 
-$menuType = (array) JFactory::getApplication()->getUserState('com_menus.items.menutype');
+$menuType = JFactory::getApplication()->getUserState('com_menus.items.menutype');
 ?>
 <button class="btn" type="button" onclick="document.getElementById('batch-menu-id').value='';document.getElementById('batch-access').value='';document.getElementById('batch-language-id').value=''" data-dismiss="modal">
 	<?php echo JText::_('JCANCEL'); ?>
 </button>
-<?php if (!empty($menuType)) : ?>
+<?php if (strlen($menuType) && $menuType != '*') : ?>
 	<button class="btn btn-success" type="submit" onclick="Joomla.submitbutton('item.batch');">
 		<?php echo JText::_('JGLOBAL_BATCH_PROCESS'); ?>
 	</button>