From 858df24689f6cbc9ba99dc49f1757ec835e3707b Mon Sep 17 00:00:00 2001 From: Allon Moritz Date: Fri, 1 Apr 2022 14:46:02 +0200 Subject: [PATCH 1/4] Convert log type field to fancy select --- administrator/components/com_actionlogs/config.xml | 1 + .../components/com_actionlogs/src/Field/LogtypeField.php | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/administrator/components/com_actionlogs/config.xml b/administrator/components/com_actionlogs/config.xml index bfb6c100dca6d..c8c6c932511c4 100644 --- a/administrator/components/com_actionlogs/config.xml +++ b/administrator/components/com_actionlogs/config.xml @@ -28,6 +28,7 @@ type="logtype" label="COM_ACTIONLOGS_LOG_EXTENSIONS_LABEL" multiple="true" + layout="joomla.form.field.list-fancy-select" default="com_banners,com_cache,com_categories,com_checkin,com_config,com_contact,com_content,com_installer,com_media,com_menus,com_messages,com_modules,com_newsfeeds,com_plugins,com_redirect,com_scheduler,com_tags,com_templates,com_users" /> Date: Fri, 1 Apr 2022 16:36:35 +0200 Subject: [PATCH 2/4] Also user profile --- plugins/system/actionlogs/forms/actionlogs.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/system/actionlogs/forms/actionlogs.xml b/plugins/system/actionlogs/forms/actionlogs.xml index f8666e112defc..215d3f9b00473 100644 --- a/plugins/system/actionlogs/forms/actionlogs.xml +++ b/plugins/system/actionlogs/forms/actionlogs.xml @@ -20,6 +20,7 @@ label="PLG_SYSTEM_ACTIONLOGS_EXTENSIONS_NOTIFICATIONS" multiple="true" validate="options" + layout="joomla.form.field.list-fancy-select" showon="actionlogsNotify:1" /> From ed8aa7efb2c7b9207530d4f2795fd19c13c381a4 Mon Sep 17 00:00:00 2001 From: Allon Moritz Date: Tue, 5 Apr 2022 15:18:30 +0200 Subject: [PATCH 3/4] simplify --- .../components/com_actionlogs/src/Field/LogtypeField.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/administrator/components/com_actionlogs/src/Field/LogtypeField.php b/administrator/components/com_actionlogs/src/Field/LogtypeField.php index fa6c34fc15dd9..f5bfaac2b134f 100644 --- a/administrator/components/com_actionlogs/src/Field/LogtypeField.php +++ b/administrator/components/com_actionlogs/src/Field/LogtypeField.php @@ -49,14 +49,13 @@ public function getOptions() $extensions = $db->setQuery($query)->loadColumn(); - $options = array(); - $tmp = array('checked' => true); + $options = []; foreach ($extensions as $extension) { ActionlogsHelper::loadTranslationFiles($extension); $option = HTMLHelper::_('select.option', $extension, Text::_($extension)); - $options[ApplicationHelper::stringURLSafe(Text::_($extension)) . '_' . $extension] = (object) array_merge($tmp, (array) $option); + $options[ApplicationHelper::stringURLSafe(Text::_($extension)) . '_' . $extension] = $option; } ksort($options); From 1c31739223797172103e534baba0b1ebc2044ff4 Mon Sep 17 00:00:00 2001 From: Allon Moritz Date: Wed, 6 Apr 2022 06:20:52 +0200 Subject: [PATCH 4/4] Simplify --- .../components/com_actionlogs/src/Field/LogtypeField.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/administrator/components/com_actionlogs/src/Field/LogtypeField.php b/administrator/components/com_actionlogs/src/Field/LogtypeField.php index f5bfaac2b134f..8d1e94420ff0d 100644 --- a/administrator/components/com_actionlogs/src/Field/LogtypeField.php +++ b/administrator/components/com_actionlogs/src/Field/LogtypeField.php @@ -54,8 +54,8 @@ public function getOptions() foreach ($extensions as $extension) { ActionlogsHelper::loadTranslationFiles($extension); - $option = HTMLHelper::_('select.option', $extension, Text::_($extension)); - $options[ApplicationHelper::stringURLSafe(Text::_($extension)) . '_' . $extension] = $option; + $extensionName = Text::_($extension); + $options[ApplicationHelper::stringURLSafe($extensionName) . '_' . $extension] = HTMLHelper::_('select.option', $extension, $extensionName); } ksort($options);