Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

# [#29694] Fix broken extension update. Thanks Viet Vu

  • Loading branch information...
commit b2534e7947d486dd1a5b8f4d2c15d57b2c4a8daa 1 parent e675a2e
Viet Vu authored infograf768 committed
View
1  installation/CHANGELOG
@@ -29,6 +29,7 @@ $ -> Language fix or change
19-Nov-2012 Jean-Marie Simonet
# [#29714] Code style fixes based on Jenkins, replace uses of JRequest. Thanks Michael.
# [#28087] PHP errors when all modules are removed. Thanks David
+ # [#29694] Fix broken extension update. Thanks Viet Vu
18-Nov-2012 Jean-Marie Simonet
# [#29684] Wrong HTML markup on category edit. Thanks Ofer
View
16 libraries/joomla/updater/adapters/extension.php
@@ -204,7 +204,21 @@ public function findUpdate($options)
{
if (isset($this->latest->client) && strlen($this->latest->client))
{
- $this->latest->client_id = JApplicationHelper::getClientInfo($this->latest->client)->id;
+ if (is_numeric($this->latest->client))
+ {
+ $byName = false;
+
+ // <client> has to be 'administrator' or 'site', numeric values are depreceated. See http://docs.joomla.org/Design_of_JUpdate
+ JLog::add(
+ 'Using numeric values for <client> in the updater xml is deprecated. Use \'administrator\' or \'site\' instead.',
+ JLog::WARNING, 'deprecated'
+ );
+ }
+ else
+ {
+ $byName = true;
+ }
+ $this->latest->client_id = JApplicationHelper::getClientInfo($this->latest->client, $byName)->id;
unset($this->latest->client);
}
$updates = array($this->latest);
Please sign in to comment.
Something went wrong with that request. Please try again.