From b27783efcef217bbe46b17e647e6df57c95cab1c Mon Sep 17 00:00:00 2001 From: Minei3oat Date: Wed, 14 Sep 2016 21:48:55 +0200 Subject: [PATCH] better performance array_filter is only needed if there are elements in the array --- libraries/cms/html/bootstrap.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/cms/html/bootstrap.php b/libraries/cms/html/bootstrap.php index 347753b9a4b8a..863369e898296 100644 --- a/libraries/cms/html/bootstrap.php +++ b/libraries/cms/html/bootstrap.php @@ -633,9 +633,9 @@ public static function startAccordion($selector = 'myAccordian', $params = array $script[] = "\t.on('hidden', " . $onHidden . ")"; } - $parents = array_key_exists(__METHOD__, static::$loaded) ? array_column(static::$loaded[__METHOD__], 'parent') : array(); + $parents = array_key_exists(__METHOD__, static::$loaded) ? array_filter(array_column(static::$loaded[__METHOD__], 'parent')) : array(); - if ($opt['parent'] && empty(array_filter($parents))) + if ($opt['parent'] && empty($parents)) { $script[] = " $(document).on('click.collapse.data-api', '[data-toggle=collapse]', function (e) {