From bacc81f4a9c7a282c2d9e69f71e03e41b831a583 Mon Sep 17 00:00:00 2001
From: Sander Potjer <github@sanderpotjer.nl>
Date: Sun, 3 Sep 2017 18:35:02 +0200
Subject: [PATCH] [com_menus] Check for edit permission linked menu modules
 (#17845)

* [com_menus] Check for edit permission linked menu modules

* Coding style

* CodeStyle
---
 .../components/com_menus/views/menus/tmpl/default.php      | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/administrator/components/com_menus/views/menus/tmpl/default.php b/administrator/components/com_menus/views/menus/tmpl/default.php
index 3fcd852f176e..5674423bce40 100644
--- a/administrator/components/com_menus/views/menus/tmpl/default.php
+++ b/administrator/components/com_menus/views/menus/tmpl/default.php
@@ -170,19 +170,20 @@
 									<ul class="dropdown-menu">
 										<?php foreach ($this->modules[$item->menutype] as &$module) : ?>
 											<li>
-												<?php if ($canEdit) : ?>
+												<?php if ($user->authorise('core.edit', 'com_modules.module.' . (int) $module->id)) : ?>
 													<?php $link = JRoute::_('index.php?option=com_modules&task=module.edit&id=' . $module->id . '&return=' . $return . '&tmpl=component&layout=modal'); ?>
 													<a href="#moduleEdit<?php echo $module->id; ?>Modal" role="button" class="button" data-toggle="modal" title="<?php echo JText::_('COM_MENUS_EDIT_MODULE_SETTINGS'); ?>">
 														<?php echo JText::sprintf('COM_MENUS_MODULE_ACCESS_POSITION', $this->escape($module->title), $this->escape($module->access_title), $this->escape($module->position)); ?></a>
 												<?php else : ?>
-													<?php echo JText::sprintf('COM_MENUS_MODULE_ACCESS_POSITION', $this->escape($module->title), $this->escape($module->access_title), $this->escape($module->position)); ?>
+													<a href="#" class="disabled" disabled="disabled">
+													    <?php echo JText::sprintf('COM_MENUS_MODULE_ACCESS_POSITION', $this->escape($module->title), $this->escape($module->access_title), $this->escape($module->position)); ?></a>
 												<?php endif; ?>
 											</li>
 										<?php endforeach; ?>
 									</ul>
 								 </div>
 								<?php foreach ($this->modules[$item->menutype] as &$module) : ?>
-									<?php if ($canEdit) : ?>
+									<?php if ($user->authorise('core.edit', 'com_modules.module.' . (int) $module->id)) : ?>
 										<?php $link = JRoute::_('index.php?option=com_modules&task=module.edit&id=' . $module->id . '&return=' . $return . '&tmpl=component&layout=modal'); ?>
 										<?php echo JHtml::_(
 												'bootstrap.renderModal',