Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click not working in Admin menu after 3.6 update #11457

Closed
fr56 opened this issue Aug 4, 2016 · 10 comments
Closed

Right click not working in Admin menu after 3.6 update #11457

fr56 opened this issue Aug 4, 2016 · 10 comments

Comments

@fr56
Copy link

fr56 commented Aug 4, 2016

Steps to reproduce the issue

Using Firefox (FF) for Windows, in Admin menu, clik on any menu item, e.g. System, and then right click on a subitem in the drop-down menu, e.g. Configuration.

Expected result

FF will show the menu for choices like Open link in new tab, Open link in new window etc.

Actual result

FF will show the menu for choices like Share this page, Show Source Code etc, and it's not possible to open the desired element in a new tab.

System information (as much as possible)

Joomla 3.6.0 or 3.6.1.
PHP 5.5.36
Isis admin template
Windows 10
Firefox version 48 (also tested on v. 45 and 47).

Additional comments

This bug started after upgrading to Joomla 3.6.0. It's the same in 3.6.1.
Tested on different sites with different PCs.
It's ok if using Chrome, Opera, Edge or IE.
Firefox for Mac v. 47 is also ok.
Hathor template is not affected.
Actually, it's the same bug in the frontend main menu on joomla.org!

@brianteeman
Copy link
Contributor

I just tried it in chrome and firefox for mac and had no problem

@fr56
Copy link
Author

fr56 commented Aug 4, 2016

Right, it seems to be only Firefox for Windows that's affected, but thanks for testing.
Anyone else here using Windows?

@yild
Copy link
Contributor

yild commented Aug 4, 2016

I can confirm this issue in 3.6.0 and 3.6.1.
Furthermore when I was playing with menu there ware times that even top level menu item would not bring FF popup menu that allow open link.

If you r-click a few times... dozens... it eventually bring popup menu, from this moment it will work in each tab (I had 3.6 and 3.6.1 sites opened simultaneously) - or maybe it was pure luck.

There ware 'places' on menu item that would bring popup menu, click on text - no effect, click on padding (or what ever space between each text in menu its called) - correct menu popup.

Tested 3.5.1 and there ware no problems like that (or I didn't encounter one).

@brianteeman
Copy link
Contributor

The css for the menus has been completely rwritten since 3.5 to allow for
scrolling when you have a very long menu

On 4 August 2016 at 21:53, yild notifications@github.com wrote:

I can confirm this issue in 3.6.0 and 3.6.1.
Furthermore when I was playing with menu there ware times that even top
level menu item would not bring FF popup menu that allow open link.

If you r-click a few times... dozens... it eventually bring popup menu,
from this moment it will work in each tab (I had 3.6 and 3.6.1 sites opened
simultaneously) - or maybe it was pure luck.

There ware 'places' on menu item that would bring popup menu, click on
text - no effect, click on padding (or what ever space between each text in
menu its called) - correct menu popup.

Tested 3.5.1 and there ware no problems like that (or I didn't encounter
one).


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11457 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eGpzQDvc93gDmm10rfWzNc0NBl5ks5qclE4gaJpZM4JdCM1
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@ggppdk
Copy link
Contributor

ggppdk commented Aug 4, 2016

It is due JS and due to the fact that:

  • firefox fires a click event (that propages up) to the document , when you press right click, and possible other events
  • other browsers do not do it (for right click)

and current JS will close the menu if a click is caught at "document",
(and firefox will show its built-in menu after the event handlers finish ?)

Adding detection for right click maybe enough to see the correct browser menu
but to keep the HTML-based menu of Joomla open will need more than catching the right click

@ggppdk
Copy link
Contributor

ggppdk commented Aug 4, 2016

I don't think this is worth the effort, just use middle click to open in new tab

@C-Lodder
Copy link
Member

C-Lodder commented Aug 5, 2016

Same issue for me on FF Beta (Windows).

I've had to start opening pages in a new tab using CTRL + click, but the fact is, people may want to perform a different action such as inspecting the element, copy link location, etc, so yes, it is worth it. I'll look into potential fixes for this over the weekend if I get a moment


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11457.

@ggppdk
Copy link
Contributor

ggppdk commented Aug 5, 2016

@C-Lodder

Of course it would be nice if this works,

Clearing menu happens here (uncompressed version JS (enabled debug)):
https://github.com/joomla/joomla-cms/blob/staging/media/jui/js/bootstrap.js#L841

    .on('click.dropdown.data-api', clearMenus)

with:

    .on('click.dropdown.data-api',
        function (e) {
                var isRightMB = 0;
                e = e || window.event;

                if ("which" in e)  // Gecko (Firefox), WebKit (Safari/Chrome) & Opera
                    isRightMB = e.which == 3; 
                else if ("button" in e)  // IE, Opera 
                    isRightMB = e.button == 2; 

                if (!isRightMB) clearMenus();
            }
    )


works , but i do not know if it will cause other problems, but the above will save you time, that you can spend on testing it


right_click_firefox

@C-Lodder
Copy link
Member

C-Lodder commented Sep 6, 2016

@brianteeman #11951

@brianteeman
Copy link
Contributor

Closed as we have a PR for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants