Edit modules stopped working with 3.6.3 update #12456

Closed
GottaLotta opened this Issue Oct 18, 2016 · 43 comments

Projects

None yet
@GottaLotta
GottaLotta commented Oct 18, 2016 edited

Steps to reproduce the issue

I am running grantry5 on the latest joomla 3.6.2. i updated to 3.6.3 and now when i go to edit a particular module, it opens the edit page, but immediately flashes to a blank screen with a dropdown in the top left corner, and the browser starts the spin of death.

Expected result

Actual result

System information (as much as possible)

Additional comments

@zero-24
Contributor
zero-24 commented Oct 18, 2016

Did you clear the caches in backend an fronted? Did it work with the default template?

@GottaLotta

yes, cache has been cleared.

i get the same result on ff and chrome.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12456.

@GottaLotta

it is related to isis template, hathor has no issues.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12456.

@mbabker
Member
mbabker commented Oct 18, 2016

Confirmed on one of my company websites. The rendered page according to Google's dev console only has the select element yet when I view the source I get the full HTML markup. This seems to imply there might be broken HTML in the layout.

@dgt41
Member
dgt41 commented Oct 18, 2016

sound like cache problem with core.js:
Let me explain bit further:
the new moduleorder field is doing some html replacement with some element target (the new code in core.js) but if you have the old core.js, cached, then this might happen.

Just clearing the browser's cache, should be enough

@mbabker
Member
mbabker commented Oct 18, 2016

That did the trick. That's highly problematic though if we are rolling an update that can't even gracefully work without a forced cache refresh.

@GottaLotta

I've cleared cache on ff and chrome, plus ctrl+5 since i am on windows, several times, still same issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12456.

@dgt41
Member
dgt41 commented Oct 18, 2016

@GottaLotta might be server caching...

@zero-24
Contributor
zero-24 commented Oct 18, 2016

Please use the reinstall button and try to clear the cache again

@GottaLotta

i've already tried reinstalling core joomla files. will try clearing server cache now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12456.
@nikhilthecool

Faced the same issue today. After upgrading from J3.6.2 to J3.6.3, Edit Module screen kept loading. Read this post and thereafter did the following:

  1. Cleared the Server Cache from Cpanel
  2. Cleared Browser Cache from Firefox

Issue solved. I'm able to edit all modules now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12456.

@GottaLotta

have reinstalled core files again
cleared site cache again
cleared browser cache on ff and chrome again
force cache refresh (ctl+f5) again
disable cache in cloudflare (reckon that is irrelevant)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12456.

@dgt41
Member
dgt41 commented Oct 18, 2016

disable cache in cloudflare (reckon that is irrelevant)

That was your problem

@brianteeman
Contributor

Absolutely expected behaviour

On 18 October 2016 at 19:03, Phil Taylor notifications@github.com wrote:

yup - 3 confirmed cases here too so far...


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12456 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eip10gClyAcTVIeMHjsgJ1iiTuRks5q1QoJgaJpZM4KaBuv
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@PhilETaylor
Contributor

If by expected behaviour you mean broken :-)

@mbabker
Member
mbabker commented Oct 18, 2016

No apparently it's expected behavior that there was a major change to the underlying assets that causes the page to stop working until a forced refresh of all assets (from whatever source) occurs.

This can't happen again. We need graceful degradation in our JavaScript. The fact that the asset refreshing is able to fatally break a page is a major issue (usually more often than not you still have a "usable" page).

@PhilETaylor
Contributor

well I think this is a candidate for https://docs.joomla.org/Category:Version_3.6.3_FAQ

@brianteeman
Contributor

Last time this happened all admin save buttons stopped working iirc

On 18 October 2016 at 19:16, Michael Babker notifications@github.com
wrote:

No apparently it's expected behavior that there was a major change to the
underlying assets that causes the page to stop working until a forced
refresh of all assets (from whatever source) occurs.

This can't happen again. We need graceful degradation in our JavaScript.
The fact that the asset refreshing is able to fatally break a page is a
major issue (usually more often than not you still have a "usable" page).


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12456 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8TTRshxGVD7NXRpYlRLD_ti3tAcDks5q1Q0agaJpZM4KaBuv
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@mbabker
Member
mbabker commented Oct 18, 2016

You still had a viewable page though. In this scenario, you're ending up with a page that only has a select list for the ordering field.

@brianteeman
Contributor

well I think this is a candidate for https://docs.joomla.org/
Category:Version_3.6.3_FAQ

Its a wiki - go for it

@dgt41
Member
dgt41 commented Oct 18, 2016

This can't happen again

You don't imply that javascript code should never, ever be updated, because there might be a need for cache clearing...

Anyways this will be fixed, once and for all, in 3.7 after the great work from @andrepereiradasilva

@zero-24
Contributor
zero-24 commented Oct 18, 2016

So we can close this here as it can be fixed by cache clearing and the next bigger version should fix this issue?

@mbabker
Member
mbabker commented Oct 18, 2016

I'm not saying that we shouldn't touch the JavaScript code. What I am trying to say though is that we can't rely on forced cache refreshes as the "fix" for these things; we should have graceful degradation mechanisms in place so that you don't end up on a page like this one where it's totally busted and totally inexplicable why you're there. It means writing more fault tolerant code. Now if there is absolutely zero way to cope with this type of change being made again in a way that causes a fatally broken view until a cache refresh happens then so be it, but it should be documented much more clearly when that happens and not a "oh, by the way, this is totally expected" after the fact.

@PhilETaylor
Contributor

@zero-24 I say leave it open 48 hours to prevent duplicates then close it :)

@dgt41
Member
dgt41 commented Oct 18, 2016

@mbabker after all this fuzz, I'll say that I should have done this differently:

  • deprecated the writeDynaList and changeDynaList form core.js as it doesn't belong there
  • use a moduleorder.js file with the new code

But I didn't, so we end up with the clear your browser's cache solution (it's not the first time that js or css are misbehaving after an update)

@mbabker
Member
mbabker commented Oct 18, 2016

I know but we've gotta get better with this. And I know Andre's work helps with things.

@visualtribe

I have the same issue on one site. However on another site the module edit page shows up. I stopped upgrading. On both sites is the same templating system Helix. I reinstalled all files, didn't help. I just tried clearing my browser cache for FireFox 49.0.1 and quit the browser. Relaunched. Went back to my modules page, clicked on module to edit, page passed and now have access to page. Click save and close, file saved and closed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12456.

@brianteeman
Contributor

@visualtribe so clearing the cache worked - awesome

On 18 October 2016 at 21:34, visualtribe notifications@github.com wrote:

I have the same issue on one site. However on another site the module edit
page shows up. I stopped upgrading. On both sites is the same templating
system Helix. I reinstalled all files, didn't help. I just tried clearing
my browser cache for FireFox 49.0.1 and quit the browser. Relaunched. Went
back to my modules page, clicked on module to edit, page passed and now

have access to page. Click save and close, file saved and closed.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/tracker/
joomla-cms/12456.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12456 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Srb1ExnhJ6TDZLDEjQoar1Aa1sWks5q1S1zgaJpZM4KaBuv
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@visualtribe

Yes. I am still cautious with the update. Will go through each site gingerly. But I have also been on that other side where people do a fix and it doesn't work for me. Hope this is all that needs to be done for people.

@webchun
webchun commented Oct 19, 2016

I experienced the same issue and clearing Chrome browser cache solved it


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12456.

@lungkao
lungkao commented Oct 19, 2016 edited

F5 or Command+r work

@msghani
msghani commented Oct 19, 2016

Hi,
Same problem I have been facing after update 3.6.3 ver & I have done everything remove all cache from browser and server but still I am facing same issue.

@wilsonge
Member

This fixes the issue for people largely it seems and we have the docs ready. @msghani please can you open a new issue with full server information as if this doesn't fix the issue for you then there's some sort of different bug occurring for you.

I'm going to therefore close this issue for now as the original issue has been fixed

@wilsonge wilsonge closed this Oct 19, 2016
@brianteeman
Contributor

@msghani well you cant have cleared all the cache ;) Dont forget that if your host provides caching then you will need to clear that as well.

For example Siteground has something called supercacher and if you are hosting with them then you will need to log in to your hosting control panel and flush the cache. The same is true if you are using a caching service such as cloudflare - Neither of these should be caching anything in the admin of your site but they do and its beyond our control

@andrepereiradasilva
Contributor

sure, for people that use CDN (or proxy cache mechanims) they need to clear the those cache too because js/css/images/etc are cached in those servers.

@brianteeman
Contributor

@andrepereiradasilva sadly many people dont know that their host even does
any caching

On 19 October 2016 at 12:49, andrepereiradasilva notifications@github.com
wrote:

sure, for people that use CDN (or proxy cache mechanims) they need to
clear the those cache too because js/css/images/etc are cached in those
servers.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12456 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bPb-ffYZPAap7jyb-mzo_YQnuwmks5q1gOxgaJpZM4KaBuv
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@PhilETaylor
Contributor

Sadly, in my experience, some people dont even know who their webhost is let alone how to contact them or the features they provide...

@zstergios
zstergios commented Oct 20, 2016 edited

I suggest to add to backend's JS/CSS files modified timestamp.
example
editor.js?t=TIMESTAMP so after update anyone will not have caching issues.

Edit:
I have created a plugin that appends the last-modified timestamp to each media file. Very useful for development under cached environments like (opcache/ nginix)
Joomla Media Cache Fixer - Force to update

@brianteeman
Contributor

@zstergios this has already been done and is already in the core. Of course you will only see the effect on the next update

@zstergios

@brianteeman Nice! Then my plugin is temporary solution. Also helps dev's when they are editing the files.
You can get a look of my plugin code, you are free ofcourse to use any part of it if you wish

@nahrafqifahs

@zstergios Nice! The plugin fix the issues and now i can access and edited the module. Thank you!

@wilsonge
Member

Sorry to be a pain, this isn't a place to advertise your extension updates. That's JED. I'm deleting your last post...

@wilsonge wilsonge locked and limited conversation to collaborators Oct 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.