Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies #13

Closed
Svel opened this issue Nov 6, 2011 · 3 comments

Comments

Projects
None yet
5 participants
@Svel
Copy link

commented Nov 6, 2011

Is this section in manifest xml working?

<dependencies>
    <dependency type="platform" name="joomla" operator="=" version="1.7.0" />
</dependencies>

Is this working for custom libraries, components, modules ?

chdemko pushed a commit to chdemko/joomla-cms that referenced this issue Nov 21, 2011

Merge pull request joomla#13 from realityking/25251
Move the rendering of HTML link elements to JDocumentRendererHead.
@dongilbert

This comment has been minimized.

Copy link
Contributor

commented Dec 29, 2012

Dependencies are not currently supported, but were added for that possibility in the future, according to Ian here: https://groups.google.com/d/msg/joomla-dev-platform/SSfpetLPESI/vuht__60B8YJ

@nicksavov

This comment has been minimized.

Copy link
Contributor

commented May 5, 2013

Hi guys,

What's the status on this one? Can/should it be closed?

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Oct 13, 2013

Thanks for reporting this. At this time we are only using github as the place to submit code fixes so I am closing the report here. The actual reporting of issues and testing fixes is still taking place on Joomlacode.

As it has been some time since you opened this issue can you please confirm that it is still valid with the current Master or Joomla 3.2 beta.

If it is still valid please can you open an item on the Joomlacode tracker in the appropriate area.

CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103

CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549

infograf768 added a commit that referenced this issue Nov 3, 2014

Merge pull request #13 from bembelimen/patch-21
Proposal for a "safer" string handling

@maxdel85 maxdel85 referenced this issue Mar 6, 2015

Closed

Error redirect #6333

wilsonge added a commit that referenced this issue Apr 7, 2016

Merge pull request #13 from zero-24/cs_admin
Some smal / automated CS improvments for the admin component

rdeutz pushed a commit that referenced this issue Apr 19, 2016

roland-d added a commit that referenced this issue May 24, 2016

[mod_login] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8') (#…
…10406)

* Update default_logout.php

* fix php errors (#13)

mwatt pushed a commit to mwatt/joomla-cms that referenced this issue Jul 2, 2016

mwatt pushed a commit to mwatt/joomla-cms that referenced this issue Jul 2, 2016

Ruchiranga added a commit to Ruchiranga/joomla-cms that referenced this issue Aug 3, 2016

Tests for permissions.js (joomla#13)
* Test suite for permissions.js
* Added karma-jasmine-ajax plugin

rdeutz added a commit that referenced this issue Aug 12, 2016

Google Summer of Code 2016 JavaScript Testing project (#11420)
* Initial test environment setup with Jasmine, Karma and RequireJS

* Seperated test setup code from test logic

* Configured .travis.yml to run Karma

* Fixed typo in .travis.yml

* changes to .travis.yml

* Added karma requirejs module

* Removed unnecessary code in travis.yml

* Fixed missing code is travis.yml

* Removed 2 unused image files

* Improved code standards

* Modified travis.yml

* Issue 1 Cleaned the mess with changes bunch of to unrelated files

* Issue 1 Added newline at end of file

* Issue 4 Improved JCaption JavaScript tests

* New coeverage reporter plugin test with Travis

* Issue 1 Added karma-coerage reporter and configured it to display coverage on console

* Issue 1 Added and configured karma-verbose-reporter plugin

* Issue 1 Fixing verbose reporter config for travis

* Issue 1 removed redundant javascript dir and added requirejs/text plugin to load fixtures

* Issue 4 Improved code with suggestions made in the code review

* Issue 1 Added version for requirejs text plugin

* Issue 1 converted space indentations to tabs

* Issue 1 Fixed indentation in package.json

* Issue 1 Fixed version issue in require text

* Issue 1 Fixed version issue in require text

* Issue 1 Fixed version issue in require text

* Issue 4 Improved code standards and jquer selector efficiency

* Issue 1 Tersting version issue with text plugin on travis

* Issue 1 Tersting version issue with text plugin on travis

* Issue 1 Tersting version issue with text plugin on travis

* Issue 1 Removed spec folder

* Corejs tests (#15)

Tests for core.js

* Tests for permissions.js (#13)

* Test suite for permissions.js
* Added karma-jasmine-ajax plugin

* Added a container div for fixtures representing library name (#11)

* Added a container div for fixtures representing the library name

* CS - Removed an extra new line

* Permissions.js tests

Test for permissions

* Repeatable.js test suite

* Improvements to JCaption tests

* README.md update

* Modified readme file
* Made running tests easier by adding configuration for tests to run on npm test

* Core js Improvements

* Issue 9 Added jasmine spies and improved code
* Issue 9 Fixed an indentation issue

* Demo video on Youtube 

* Inserted the video demonstration link to the readme

* Issue 5 Added spies and made code improvements (#31)

* Issue 12 Improved code (#34)

* Repeatable.js Improvements (#35)

* Run Travis JavaScript tests on separated Matrix Build (#39)

* Only run Travis tests on PHP 7

* Fix base path issue

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Reverted README.md

* Synced README.md to the new version

* Synced README.md with new version

* Fixed indentations

* Synced README.md with 3.6 version

* Fixed indentations

* Fixed indentations
* Added newline at the end of travis-tests.sh

* Added missing sudo:false in .travis.yml

roland-d referenced this issue in roland-d/joomla-cms Sep 11, 2016

Google Summer of Code 2016 JavaScript Testing project (joomla#11420)
* Initial test environment setup with Jasmine, Karma and RequireJS

* Seperated test setup code from test logic

* Configured .travis.yml to run Karma

* Fixed typo in .travis.yml

* changes to .travis.yml

* Added karma requirejs module

* Removed unnecessary code in travis.yml

* Fixed missing code is travis.yml

* Removed 2 unused image files

* Improved code standards

* Modified travis.yml

* Issue 1 Cleaned the mess with changes bunch of to unrelated files

* Issue 1 Added newline at end of file

* Issue 4 Improved JCaption JavaScript tests

* New coeverage reporter plugin test with Travis

* Issue 1 Added karma-coerage reporter and configured it to display coverage on console

* Issue 1 Added and configured karma-verbose-reporter plugin

* Issue 1 Fixing verbose reporter config for travis

* Issue 1 removed redundant javascript dir and added requirejs/text plugin to load fixtures

* Issue 4 Improved code with suggestions made in the code review

* Issue 1 Added version for requirejs text plugin

* Issue 1 converted space indentations to tabs

* Issue 1 Fixed indentation in package.json

* Issue 1 Fixed version issue in require text

* Issue 1 Fixed version issue in require text

* Issue 1 Fixed version issue in require text

* Issue 4 Improved code standards and jquer selector efficiency

* Issue 1 Tersting version issue with text plugin on travis

* Issue 1 Tersting version issue with text plugin on travis

* Issue 1 Tersting version issue with text plugin on travis

* Issue 1 Removed spec folder

* Corejs tests (joomla#15)

Tests for core.js

* Tests for permissions.js (#13)

* Test suite for permissions.js
* Added karma-jasmine-ajax plugin

* Added a container div for fixtures representing library name (#11)

* Added a container div for fixtures representing the library name

* CS - Removed an extra new line

* Permissions.js tests

Test for permissions

* Repeatable.js test suite

* Improvements to JCaption tests

* README.md update

* Modified readme file
* Made running tests easier by adding configuration for tests to run on npm test

* Core js Improvements

* Issue 9 Added jasmine spies and improved code
* Issue 9 Fixed an indentation issue

* Demo video on Youtube 

* Inserted the video demonstration link to the readme

* Issue 5 Added spies and made code improvements (joomla#31)

* Issue 12 Improved code (joomla#34)

* Repeatable.js Improvements (joomla#35)

* Run Travis JavaScript tests on separated Matrix Build (joomla#39)

* Only run Travis tests on PHP 7

* Fix base path issue

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Reverted README.md

* Synced README.md to the new version

* Synced README.md with new version

* Fixed indentations

* Synced README.md with 3.6 version

* Fixed indentations

* Fixed indentations
* Added newline at the end of travis-tests.sh

* Added missing sudo:false in .travis.yml

wilsonge pushed a commit that referenced this issue Jan 23, 2017

proman24 added a commit to proman24/joomla-cms that referenced this issue Aug 18, 2018

Custom width (joomla#13)
* Adding more Fields to the front-end

* Sending and receiveing Widths through ajax

* updateing controller for requested widths

* Added Multiple Focus Areas for diffrent widths

* Added  translatable strings

* resolveing merge conflicts

* phpcs

* phpcs

* added new lines

* updated ajax for getFocusPoints

* build

* updateing ajax for all and build

* removed data fields

* Added Base for custom width

* Fetching the parameters

* Added custom widths to the front end

* build

* adjustng widths in the controller

* pulled upstream

* phpcs

* fix

* fix

* Update smartcrop.xml

* codestyle

* removed break statement

* fix

* build

* lines before control statement

* fix

* fix

continga pushed a commit to continga/joomla-cms that referenced this issue Sep 24, 2018

Rene Pasing
This is a combination of 19 commits.
This is the 1st commit message:

First WIP version of supporting nested subforms.

This is the commit message joomla#2:

Fix nested subforms not getting correct name attribute on input fields.

This is the commit message joomla#3:

Fix subform rows having invalid index, fix small typo.

This is the commit message joomla#4:

Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process.

This is the commit message joomla#5:

Implement feedback from PR at Joomla;
- Use a <template> HTML element for the template of the subform rows,
  not a url encoded string inside of a <script> element.
- Fix code style errors reported by phpcs.
- Make the fixing of the unique attributes (name, id, etc) of input elements
  of nested subform rows more errorprone, using the same method as the main
  subform row.
- Manually add a minified version of the javascript file.

This is the commit message joomla#6:

Fix failing javascript tests due to changed structure of subform repeatable template container.

This is the commit message joomla#7:

Change subform repeatable javascript test to correctly check on
0-indexed rows, previously they have been 1-indexed.

This is the commit message joomla#8:

Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly.
Additionally added a note why the fixScripts() method is broken and how it could get better.

This is the commit message joomla#9:

First commit which integrates the subform custom field type.

This is the commit message joomla#10:

Rename manifest file for plg_fields_subform

This is the commit message joomla#11:

plg_fields_subform: Improve code comments and made the subform field type optionally non-repeatable.

This is the commit message joomla#12:

Fix not being able to change the type of a subfield.

This is the commit message joomla#13:

Implement a small in-memory renderCache for subform custom fields

This is the commit message joomla#14:

Prepare to load the subfields into a subform custom field directly via their own xml definition.

This is the commit message joomla#15:

After merge with PR joomla#17552 we can now successfully show the subforms options for the different types.

This is the commit message joomla#16:

The subform custom field type doesnt need a default value.

This is the commit message joomla#17:

Implement an option for a subform customfield to disable rendering the field values.

This is the commit message joomla#18:

Remove unused code and set hidden fields to not-required.

This is the commit message joomla#19:

Reset for dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.