New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_fields] Automatic Display in User Context doesn´t apply in this context #14377

Closed
coolcat-creations opened this Issue Mar 6, 2017 · 33 comments

Comments

Projects
None yet
9 participants
@coolcat-creations
Contributor

coolcat-creations commented Mar 6, 2017

image

Maybe i´m missing something but there is no after Display, before Display and After Title in User?
Can this field be removed in User-Context?

Also if i set this option to no, the field is still displayed.

@coolcat-creations coolcat-creations changed the title from [com_fields] Automatic Display in User Context makes no sense? to [com_fields] Automatic Display in User Context doesn´t apply in this context Mar 6, 2017

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo Mar 7, 2017

Member

Difficult to solve.

Member

laoneo commented Mar 7, 2017

Difficult to solve.

@coolcat-creations

This comment has been minimized.

Show comment
Hide comment
@coolcat-creations

coolcat-creations Mar 7, 2017

Contributor

Idea from a nondev :) can the showon parameter help?

Contributor

coolcat-creations commented Mar 7, 2017

Idea from a nondev :) can the showon parameter help?

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo Mar 7, 2017

Member

Not really, we need to do some kind of callback to the extension if it supports the automatic display events. Another thing the extension dev needs to take care of when she wants to integrate com_fields into their extension.

Member

laoneo commented Mar 7, 2017

Not really, we need to do some kind of callback to the extension if it supports the automatic display events. Another thing the extension dev needs to take care of when she wants to integrate com_fields into their extension.

@joomla-cms-bot joomla-cms-bot changed the title from [com_fields] Automatic Display in User Context doesn´t apply in this context to [com_fields] Automatic Display in User Context makes no sense? Mar 30, 2017

@joomla-cms-bot joomla-cms-bot changed the title from [com_fields] Automatic Display in User Context makes no sense? to [com_fields] Automatic Display in User Context doesn´t apply in this context Apr 4, 2017

@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed Apr 13, 2017

Contributor

Same problem also for Contact Field.
For me we need at least write in the tooltip that it is only for article and not for Users and Contact.

Contributor

AlexRed commented Apr 13, 2017

Same problem also for Contact Field.
For me we need at least write in the tooltip that it is only for article and not for Users and Contact.

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Apr 13, 2017

Member

The tooltip shouldn't say that. To "really" fix this the field would have to be aware of the supported plugin events for a context. It is not restricted/available to articles only, it just so happens of the core components only articles supports all of the listed contexts.

Member

mbabker commented Apr 13, 2017

The tooltip shouldn't say that. To "really" fix this the field would have to be aware of the supported plugin events for a context. It is not restricted/available to articles only, it just so happens of the core components only articles supports all of the listed contexts.

@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed Apr 13, 2017

Contributor

Fantastic, can your fix hide the "Automatic Display" parameter only in user and contact field ?

Contributor

AlexRed commented Apr 13, 2017

Fantastic, can your fix hide the "Automatic Display" parameter only in user and contact field ?

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Apr 13, 2017

Member

It's basically what @laoneo last comment says. When generating that field, it would have to be smart enough to call into the "owning" extension for a context to figure out what events it displays and build the list that way versus the current hardcoded list that exists now. So programmatically once the callback thing is sorted out it's an easy fix, problem is getting to that point isn't easy.

Member

mbabker commented Apr 13, 2017

It's basically what @laoneo last comment says. When generating that field, it would have to be smart enough to call into the "owning" extension for a context to figure out what events it displays and build the list that way versus the current hardcoded list that exists now. So programmatically once the callback thing is sorted out it's an easy fix, problem is getting to that point isn't easy.

@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed Apr 13, 2017

Contributor

And in this mode I hope we can set different default "permission" for a context.
Allowed "Edit Custom Field Value" for User and Contact Mail fields :)

Contributor

AlexRed commented Apr 13, 2017

And in this mode I hope we can set different default "permission" for a context.
Allowed "Edit Custom Field Value" for User and Contact Mail fields :)

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo Apr 13, 2017

Member

You can change the install script, that com_contact will have different default permissions. That's doable.

Member

laoneo commented Apr 13, 2017

You can change the install script, that com_contact will have different default permissions. That's doable.

@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed Apr 14, 2017

Contributor

Please @laoneo help me to change the install script, that com_contact will have Allowed "Edit Custom Field Value" default "permission" and help me to set the contact field for "Mail" by default. If we fix it for me we can keep contact custom field in Joomla 3.7.0.
But for me we need to hide in Joomla 3.7.0 the users custom field (like for the new router problems), the bugs 15194 and 13601 make it unusable. And restore it in Joomla 3.7.1 if we fix it.

Contributor

AlexRed commented Apr 14, 2017

Please @laoneo help me to change the install script, that com_contact will have Allowed "Edit Custom Field Value" default "permission" and help me to set the contact field for "Mail" by default. If we fix it for me we can keep contact custom field in Joomla 3.7.0.
But for me we need to hide in Joomla 3.7.0 the users custom field (like for the new router problems), the bugs 15194 and 13601 make it unusable. And restore it in Joomla 3.7.1 if we fix it.

@joeforjoomla

This comment has been minimized.

Show comment
Hide comment
@joeforjoomla

joeforjoomla Apr 14, 2017

Contributor

@AlexRed proposed a quite dramatic solution... however i agree with him that the release can't take place until everything is stable. Me and other people can't understand why the RC1 and RC2 is going on to be released even if problems are still present. It's still not time of an RC at all!

Contributor

joeforjoomla commented Apr 14, 2017

@AlexRed proposed a quite dramatic solution... however i agree with him that the release can't take place until everything is stable. Me and other people can't understand why the RC1 and RC2 is going on to be released even if problems are still present. It's still not time of an RC at all!

@rdeutz

This comment has been minimized.

Show comment
Hide comment
@rdeutz

rdeutz Apr 14, 2017

Contributor

because software is never bug free, you will never release anything when you wait till all problems are fixed

Contributor

rdeutz commented Apr 14, 2017

because software is never bug free, you will never release anything when you wait till all problems are fixed

@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed Apr 14, 2017

Contributor

Nobody ever said that before release must be resolved all the know problems. But the most important yes. When the administrator active the user all the data in the profile custom field are erased, and also the user can't find the profile custom field in the edit profile page in control panel. For me make it unusable.
The other problems in custom field can remain (14049, 15173, 14377, 15294, 15305, ecc..)

Contributor

AlexRed commented Apr 14, 2017

Nobody ever said that before release must be resolved all the know problems. But the most important yes. When the administrator active the user all the data in the profile custom field are erased, and also the user can't find the profile custom field in the edit profile page in control panel. For me make it unusable.
The other problems in custom field can remain (14049, 15173, 14377, 15294, 15305, ecc..)

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo Apr 15, 2017

Member

@AlexRed the problem with com_users is that it behaves in many places totally different, then any other extension. Rewriting that takes a big amount of time.

Member

laoneo commented Apr 15, 2017

@AlexRed the problem with com_users is that it behaves in many places totally different, then any other extension. Rewriting that takes a big amount of time.

@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed Apr 15, 2017

Contributor

Please @laoneo help me to change the install script, that com_contact will have Allowed "Edit Custom Field Value" default "permission" and help me to set the contact field for "Mail" by default.
About the com_users we can hide in Joomla 3.7.0 the users custom field (like for the new router problems) if rewriting that takes a big amount of time. And restore it in Joomla 3.7.1 or later if we fix it.

Contributor

AlexRed commented Apr 15, 2017

Please @laoneo help me to change the install script, that com_contact will have Allowed "Edit Custom Field Value" default "permission" and help me to set the contact field for "Mail" by default.
About the com_users we can hide in Joomla 3.7.0 the users custom field (like for the new router problems) if rewriting that takes a big amount of time. And restore it in Joomla 3.7.1 or later if we fix it.

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Apr 15, 2017

Member

Please stop comparing the handling of the router to any other action. To be blunt, that decision was more politically driven than a code functionality decision. The fix for any issue is not "hide the feature and re-enable when working", that should only be an option considered for critically broken code and unless I'm mistaken this is not critically broken.

Member

mbabker commented Apr 15, 2017

Please stop comparing the handling of the router to any other action. To be blunt, that decision was more politically driven than a code functionality decision. The fix for any issue is not "hide the feature and re-enable when working", that should only be an option considered for critically broken code and unless I'm mistaken this is not critically broken.

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo Apr 15, 2017

Member

Agree @mbabker.

@AlexRed honestly I don't understand what you want to achieve. com_contact has that permission already, so there is no change needed.

Member

laoneo commented Apr 15, 2017

Agree @mbabker.

@AlexRed honestly I don't understand what you want to achieve. com_contact has that permission already, so there is no change needed.

@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed Apr 15, 2017

Contributor

Sorry for my bad english, now I try with some images to explain:

have Allowed "Edit Custom Field Value" default "permission"
contact-permission01

set "Mail" by default
default-mail

Contributor

AlexRed commented Apr 15, 2017

Sorry for my bad english, now I try with some images to explain:

have Allowed "Edit Custom Field Value" default "permission"
contact-permission01

set "Mail" by default
default-mail

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Apr 15, 2017

Contributor

@laoneo I think he wants to have different default behaviors for the com_contact.mail and com_contact.contact contexts. Eg the mail one should be allowed to edit by default and the contact one should not.

But the way our permission system works, that is not something we can or even should do.

Contributor

Bakual commented Apr 15, 2017

@laoneo I think he wants to have different default behaviors for the com_contact.mail and com_contact.contact contexts. Eg the mail one should be allowed to edit by default and the contact one should not.

But the way our permission system works, that is not something we can or even should do.

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo Apr 15, 2017

Member

@Bakual I guess this is possible, with more sections in the access.xml file.

@AlexRed now I got the use case, you want to enable it initially for the Public user groups. It makes sense for first time users, but I'm not sure if this would be a good decision from security point of view.

Member

laoneo commented Apr 15, 2017

@Bakual I guess this is possible, with more sections in the access.xml file.

@AlexRed now I got the use case, you want to enable it initially for the Public user groups. It makes sense for first time users, but I'm not sure if this would be a good decision from security point of view.

@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed Apr 15, 2017

Contributor

and set "Mail" by default ?

Contributor

AlexRed commented Apr 15, 2017

and set "Mail" by default ?

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo Apr 15, 2017

Member

That can be done, but when I would go to the contacts component, I personally would expect that custom fields are shown for the contacts by default and not the form. But this is my personal opinion.

Member

laoneo commented Apr 15, 2017

That can be done, but when I would go to the contacts component, I personally would expect that custom fields are shown for the contacts by default and not the form. But this is my personal opinion.

@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed Apr 15, 2017

Contributor

can add new custom fields in the mail form is a fantastic solutions now. For me the users want it and it is not so simple to understand the we need to change the dropdown. All the users I ask to do a new contact form with some new field have failed.

Contributor

AlexRed commented Apr 15, 2017

can add new custom fields in the mail form is a fantastic solutions now. For me the users want it and it is not so simple to understand the we need to change the dropdown. All the users I ask to do a new contact form with some new field have failed.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Apr 15, 2017

Contributor

And if you change the default to mail you will say
All the users i asked to do a new contact details with some new field have failed.

The problem is not what is the default. The problem is that switching the context is not obvious at all and is a new concept for Joomla so it is unfamiliar

Contributor

brianteeman commented Apr 15, 2017

And if you change the default to mail you will say
All the users i asked to do a new contact details with some new field have failed.

The problem is not what is the default. The problem is that switching the context is not obvious at all and is a new concept for Joomla so it is unfamiliar

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo Apr 15, 2017

Member

What can we do to make it more obvious?

Member

laoneo commented Apr 15, 2017

What can we do to make it more obvious?

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Apr 15, 2017

Contributor
Contributor

brianteeman commented Apr 15, 2017

@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed Apr 15, 2017

Contributor

for example split out in TAB, like in the new Editor - TinyMCE settings for the 3 SET.
The 3 tab would be visible with the 3 options
Mail form | Contact details | Category

Contributor

AlexRed commented Apr 15, 2017

for example split out in TAB, like in the new Editor - TinyMCE settings for the 3 SET.
The 3 tab would be visible with the 3 options
Mail form | Contact details | Category

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Apr 15, 2017

Contributor

I am not convinced changing a drop down select to a tab is much better but it is more consistent with other UI patterns in Joomla.

Contributor

brianteeman commented Apr 15, 2017

I am not convinced changing a drop down select to a tab is much better but it is more consistent with other UI patterns in Joomla.

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Apr 15, 2017

Contributor

I guess this is possible, with more sections in the access.xml file.

I fear that would break more stuff than it helps. And you still would have to set public to default for that section and action which really isn't something I would do. ACL should be denied by default in all cases, that's how ACL works.

Contributor

Bakual commented Apr 15, 2017

I guess this is possible, with more sections in the access.xml file.

I fear that would break more stuff than it helps. And you still would have to set public to default for that section and action which really isn't something I would do. ACL should be denied by default in all cases, that's how ACL works.

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo Apr 15, 2017

Member

I was talking about having different permissions per context and not just from component to the field.

Member

laoneo commented Apr 15, 2017

I was talking about having different permissions per context and not just from component to the field.

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Apr 15, 2017

Contributor

I was talking about having different permissions per context and not just from component to the field.

That's how I understood you, yes. But it's not as easy as it may sound and would need several adjustments all around the (com_field) code to take care of that special case.

Contributor

Bakual commented Apr 15, 2017

I was talking about having different permissions per context and not just from component to the field.

That's how I understood you, yes. But it's not as easy as it may sound and would need several adjustments all around the (com_field) code to take care of that special case.

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo May 9, 2017

Member

Please test #15915 which should fix that issue. At the end of the day it was not so a hard and opens the door for new possibilities.

Member

laoneo commented May 9, 2017

Please test #15915 which should fix that issue. At the end of the day it was not so a hard and opens the door for new possibilities.

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo May 9, 2017

Member

Guess can be closed?

Member

laoneo commented May 9, 2017

Guess can be closed?

@Bakual Bakual closed this May 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment