New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_fields] 'Show Label' - > 'Hide' has no effect in contact and (user) profile views #15304

Closed
nordmograph opened this Issue Apr 14, 2017 · 12 comments

Comments

Projects
None yet
7 participants
@nordmograph

nordmograph commented Apr 14, 2017

Steps to reproduce the issue

Create a new field in Joomla contacts or Joomla users. In field settings, Options tab, set the 'Show Label' option to 'Hide'

Expected result

The field label should not be displayed when the field is rendered in contact and profile views (default layouts) (working as expected in Articles)

Actual result

Field Label keeps showing

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Apr 14, 2017

Issue confirmed on Contact and Users.

System information

3.7.0-rc2 (nightly Build)
macOS Sierra, 10.12.4
Firefox 52 (64-bit)

MAMP 4.1.1

  • PHP 7.0.15
  • MySQLi 5.6.35

franz-wohlkoenig commented Apr 14, 2017

Issue confirmed on Contact and Users.

System information

3.7.0-rc2 (nightly Build)
macOS Sierra, 10.12.4
Firefox 52 (64-bit)

MAMP 4.1.1

  • PHP 7.0.15
  • MySQLi 5.6.35
@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed Apr 14, 2017

Contributor

Seems related to #14377 #15244
Unfortunately currently is not possible to change the Field parameter for a context (com content, com user, com contact or external component)

Contributor

AlexRed commented Apr 14, 2017

Seems related to #14377 #15244
Unfortunately currently is not possible to change the Field parameter for a context (com content, com user, com contact or external component)

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Apr 14, 2017

Contributor

Nope, this is not related to the other issues. It's just that com_contact has an override for the field layout and that one doesn't check the label parameter.
See https://github.com/joomla/joomla-cms/blob/staging/components/com_contact/layouts/field/render.php
I don't know about the user one, that one should use the regular layout as far as I know.

The regular JLayout is this one: https://github.com/joomla/joomla-cms/blob/staging/components/com_fields/layouts/field/render.php

Contributor

Bakual commented Apr 14, 2017

Nope, this is not related to the other issues. It's just that com_contact has an override for the field layout and that one doesn't check the label parameter.
See https://github.com/joomla/joomla-cms/blob/staging/components/com_contact/layouts/field/render.php
I don't know about the user one, that one should use the regular layout as far as I know.

The regular JLayout is this one: https://github.com/joomla/joomla-cms/blob/staging/components/com_fields/layouts/field/render.php

@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed Apr 14, 2017

Contributor

oppsss... sorry
then a new bug for the custom fields

Contributor

AlexRed commented Apr 14, 2017

oppsss... sorry
then a new bug for the custom fields

@nordmograph

This comment has been minimized.

Show comment
Hide comment
@nordmograph

nordmograph Apr 14, 2017

Well com_users doesn't use an override yet for the field layout it doesn't use either the regular JLayout

At least it can be easily addressed for com_contact


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15304.

nordmograph commented Apr 14, 2017

Well com_users doesn't use an override yet for the field layout it doesn't use either the regular JLayout

At least it can be easily addressed for com_contact


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15304.

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo Apr 15, 2017

Member

If I'm not wrong, but com_users uses JForm to show the fields. It has a totally different behavior than com_contact. But yes, com_contact should have the same behavior as com_content.

Member

laoneo commented Apr 15, 2017

If I'm not wrong, but com_users uses JForm to show the fields. It has a totally different behavior than com_contact. But yes, com_contact should have the same behavior as com_content.

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Apr 21, 2017

Contributor

@laoneo can you do than a PR for fix the com_contact behavior?

Contributor

zero-24 commented Apr 21, 2017

@laoneo can you do than a PR for fix the com_contact behavior?

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo May 3, 2017

Member

Please test the pr #15756 which should fix the contact label hide issue.

Member

laoneo commented May 3, 2017

Please test the pr #15756 which should fix the contact label hide issue.

@joomla-cms-bot

This comment has been minimized.

Show comment
Hide comment
@joomla-cms-bot

joomla-cms-bot commented May 3, 2017

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig commented May 3, 2017

closed as having PR #15756


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15304.

@AlexRed

This comment has been minimized.

Show comment
Hide comment
@AlexRed

AlexRed May 16, 2017

Contributor

but the PR is only for the contact, the problem is also in the user, please reopen.

Contributor

AlexRed commented May 16, 2017

but the PR is only for the contact, the problem is also in the user, please reopen.

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo May 16, 2017

Member

As already said, the profile view is a form and has a totally different set up. I suggest to open a new issue for that one as the logic is very different then the rest of Joomla.

Member

laoneo commented May 16, 2017

As already said, the profile view is a form and has a totally different set up. I suggest to open a new issue for that one as the logic is very different then the rest of Joomla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment