Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Redirect Issue after 3.7 upgrade #15730

Closed
soap47 opened this issue May 2, 2017 · 74 comments
Closed

Login Redirect Issue after 3.7 upgrade #15730

soap47 opened this issue May 2, 2017 · 74 comments

Comments

@soap47
Copy link

@soap47 soap47 commented May 2, 2017

Steps to reproduce the issue

Upgrade to 3.7 or on a new 3.7 Joomla installation set the home menu item to Access = Registered

Expected result

Redirect to Login Page

Actual result

The page isn't redirecting properly error

System information (as much as possible)

Joomla 3.7
php 5.5.30 & 7.1.1

Additional comments

- http://localhost/testjoomla
- Will redirect to: http://localhost/testjoomla/index.php/component/users/?view=login&Itemid=101 (ERROR)
- Removing the: &Itemid=101 (WORKS)
@tonypartridge

This comment has been minimized.

Copy link
Contributor

@tonypartridge tonypartridge commented May 2, 2017

Confirmed.

@wilsonge You are familiar with the router now 🤣 suggestions...

@Stevec4

This comment has been minimized.

Copy link

@Stevec4 Stevec4 commented May 2, 2017

Confirmed as well

@PhilETaylor

This comment has been minimized.

Copy link
Contributor

@PhilETaylor PhilETaylor commented May 2, 2017

What is your menu item with id 101? and is that published and has ACL allowing access?

@soap47

This comment has been minimized.

Copy link
Author

@soap47 soap47 commented May 2, 2017

@PhilETaylor The &Itemid=101 is copied from a new 3.7 installation and it's the redirection of the default home page i just changed the menu item's access to registered nothing else.

@PhilETaylor

This comment has been minimized.

Copy link
Contributor

@PhilETaylor PhilETaylor commented May 2, 2017

Sounds like you have not got a menu item for the login page - create one and you will see that Joomla redirects to it correctly.

@brianteeman

This comment has been minimized.

Copy link
Contributor

@brianteeman brianteeman commented May 2, 2017

@PhilETaylor

This comment has been minimized.

Copy link
Contributor

@PhilETaylor PhilETaylor commented May 2, 2017

Fact is that ItemId 101 is the home page - and you cannot have no login page (without a menu item = itemid) and set the home page to registered only - you will put Joomla into a loop.

This is not a Joomla issue - this is a site configuration issue.

If you really must set your HOMEPAGE as registered, then you MUST have a different menu item, of type public, of type Login Form, so that users can be redirected to that menu item (Itemid) in order to login.

@tonypartridge

This comment has been minimized.

Copy link
Contributor

@tonypartridge tonypartridge commented May 2, 2017

Eitherway, we cannot expect all users to be configuration gurus and this scenario can occur.

I suggest we add a check on BeforeSave that the menu item is not the homepage when saving the access level. OR set access level to read only for the homepage menu item.

@PhilETaylor

This comment has been minimized.

Copy link
Contributor

@PhilETaylor PhilETaylor commented May 2, 2017

I suggest we add a check on BeforeSave that the menu item is not the homepage when saving the access level. OR set access level to read only for the homepage menu item.

Neither - its a valid use case that the home page can be set to only registered users - but if you are "guru" enough to attempt that you should be "guru" enough to add a PUBLIC login page!

Its not rocket science!

@tonypartridge

This comment has been minimized.

Copy link
Contributor

@tonypartridge tonypartridge commented May 2, 2017

No one said it was, but a user can just set the home page to registered to require a login to the website so they would expect it to work. Why would they naturally assume they need to create a login page for the automatic redirection of the homepage.

That is poor UX to assume that people should know they need to create another menu item to make the current menu item restricted. When we can educate users with a simple check.

@PhilETaylor

This comment has been minimized.

Copy link
Contributor

@PhilETaylor PhilETaylor commented May 2, 2017

There are a million things we allow users to do to destroy their site, that we don't warn them against...

Personally I would prefer that we DID NOT redirect to a login page when visiting a registered level url - but show a 403 Forbidden message - but thats not what we do with the home page for some reason...

When we can educate users with a simple check.

I doubt it would be a simple check... "home" is a very subjective place.

@soap47

This comment has been minimized.

Copy link
Author

@soap47 soap47 commented May 2, 2017

Creating a Login Menu Item in a hidden menu worked.
@brianteeman I had 5 sites registered only and worked correctly up until 3.7 upgrade.

P.S. Do i need to do anything with this Issue (Close Issue?)

@PhilETaylor

This comment has been minimized.

Copy link
Contributor

@PhilETaylor PhilETaylor commented May 2, 2017

"home" was changed as part of the customisable joomla admin menus... so maybe something there broke something ...

@soap47

This comment has been minimized.

Copy link
Author

@soap47 soap47 commented May 2, 2017

I have created Login Menu Item but now every now and then it gives me a blank page.
If i deactivate System - Page Cache it redirects correctly.

@PhilETaylor

This comment has been minimized.

Copy link
Contributor

@PhilETaylor PhilETaylor commented May 2, 2017

clear your browser cache - its probably got the caching cached. (restart the browser if chrome too)

@soap47

This comment has been minimized.

Copy link
Author

@soap47 soap47 commented May 2, 2017

I even checked it on a fresh installed Opera still getting blank pages

@tonypartridge

This comment has been minimized.

Copy link
Contributor

@tonypartridge tonypartridge commented May 2, 2017

This is a known issue with Joomla! 3.7.0 @soap47 caching will not generate a 404 on the second visit. It is resolved in 3.7.1.

@PhilETaylor

This comment has been minimized.

Copy link
Contributor

@PhilETaylor PhilETaylor commented May 2, 2017

If i deactivate System - Page Cache it redirects correctly.

Known issue addressed in other issues/pr's - please search and you will find!

#15674

@Stevec4

This comment has been minimized.

Copy link

@Stevec4 Stevec4 commented May 3, 2017

@mattske

This comment has been minimized.

Copy link

@mattske mattske commented May 5, 2017

All, please pardon my ignorance on the issue resolution process for reported defects. I see this issue is still open, but I can't tell from reading the comments whether it will be fixed in an upcoming build. The reason I ask is because I have been configuring Joomla sites in this manner (Home and all other menus set to Registered or other group permission) since Joomla 1.5. I currently have 12 sites configured in this manner. They will break if I upgrade.

@DavidBoggitt

This comment has been minimized.

Copy link

@DavidBoggitt DavidBoggitt commented May 5, 2017

This royally screwed up a company intranet I built when updating to 3.7.0. In this case the default home page was registered but there was a 3rd party login module associated with that menu item. On logging in, all was fine.

The redirects stuffed this up, but this thread saved me thankfully! So, to answer @brianteeman's question from earlier, there was a situation where having all pages registered worked in the past!

Cheers.

Dave.

@brianteeman

This comment has been minimized.

Copy link
Contributor

@brianteeman brianteeman commented May 5, 2017

@DavidBoggitt Thanks for confirming that it used to work. I was asking as I remembered a blog post in the past regarding setting your site offline and modifying the code there for this use case. But I guess I must have had a very long memory and that it was for Joomla 1 or 1.5

@tonypartridge

This comment has been minimized.

Copy link
Contributor

@tonypartridge tonypartridge commented May 5, 2017

It's likely due to the redirect, we will need to check the segmentation and if redirect to com_users do not require a menu item before forcing the redirect. It all falls back down to the old Joomla! Must have a menu item issue and I suspect the issue that is now happening is because of the new router implementation / revert.

@alexgarel

This comment has been minimized.

Copy link

@alexgarel alexgarel commented May 9, 2017

I got the problem here too. The thing is that having home set to "registered" (and all other page) sends to /it/component/users/?view=login&Itemid=<home_item_id_here> and again and again. While requesting only /it/component/users/?view=login would work.
As indicated above I added a public menu with the login form and it resolved the problem.

@kmdm

This comment has been minimized.

Copy link

@kmdm kmdm commented May 17, 2017

Just another confirmation from me: Worked fine in v3.6.4, stopped working when I just upgraded to v3.7.1.

Solely adding the menu link fixed the problem.

@PhilETaylor

This comment has been minimized.

Copy link
Contributor

@PhilETaylor PhilETaylor commented May 17, 2017

stopped working when I just upgraded to v3.7.1.

Do you mean 3.7.0 or 3.7.1 ?

@kmdm

This comment has been minimized.

Copy link

@kmdm kmdm commented May 17, 2017

I mean v3.7.1 (I upgraded to the security fix release before reading that it only affected v3.7.0 anyway)

@mattske

This comment has been minimized.

Copy link

@mattske mattske commented May 19, 2017

This issue is still open and unassigned. I am wondering if it will be fixed in a future 3.7.x service pack, or if I need to go ahead and add a public login module to all of my sites so I can upgrade. I prefer to keep my sites at the latest version to ensure they are protected from security vulnerabilities. On the other hand, the auto-redirect to the login page when Home is set to Registered is a very handy feature. If it will get fixed in an upcoming service pack, then I'll wait on upgrading my sites. I'd rather not spend the time reconfiguring them with a public login module so I can upgrade now, only to see this feature get fixed in an upcoming service pack and then revert.

@csthomas

This comment has been minimized.

Copy link
Contributor

@csthomas csthomas commented Dec 18, 2017

Please test #19099

@infograf768

This comment has been minimized.

Copy link
Member

@infograf768 infograf768 commented Dec 18, 2017

@csthomas
Sorry your patch totally breaks automatic language change on multingual sites and that even if we only use the login module and the home page is not set as registered

@joomla-cms-bot

This comment has been minimized.

Copy link

@joomla-cms-bot joomla-cms-bot commented Dec 18, 2017

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15730

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Dec 18, 2017

closed as having Pull Request #19099

@joomla-cms-bot

This comment has been minimized.

Copy link

@joomla-cms-bot joomla-cms-bot commented Dec 18, 2017

Set to "open" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15730

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Dec 18, 2017

reopened as Comment of @infograf768 .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15730.

@tonypartridge

This comment has been minimized.

Copy link
Contributor

@tonypartridge tonypartridge commented Dec 18, 2017

@csthomas

This comment has been minimized.

Copy link
Contributor

@csthomas csthomas commented Dec 21, 2017

I solved issues mentioned by @infograf768 and @senderdc. I invite you to the next tests.

@Quy

This comment has been minimized.

Copy link
Contributor

@Quy Quy commented Dec 21, 2017

@franz-wohlkoenig Close this issue due to success test per @senderdc of PR #19099?

@joomla-cms-bot

This comment has been minimized.

Copy link

@joomla-cms-bot joomla-cms-bot commented Dec 21, 2017

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15730

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Dec 21, 2017

true > closed asstated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15730.

@rpmconsulting

This comment has been minimized.

Copy link

@rpmconsulting rpmconsulting commented Feb 23, 2018

I am having this issue and all my pages and home menu are set to public. my site is on maint. mode offline page. I did the update from 3.8.3 to 3.8.5. It's in a constant loop to index.php. I did not make any other site changes other than the point update.

@tonypartridge

This comment has been minimized.

Copy link
Contributor

@tonypartridge tonypartridge commented Feb 23, 2018

@rpmconsulting

This comment has been minimized.

Copy link

@rpmconsulting rpmconsulting commented Feb 23, 2018

@tonypartridge

This comment has been minimized.

Copy link
Contributor

@tonypartridge tonypartridge commented Feb 23, 2018

@rpmconsulting

This comment has been minimized.

Copy link

@rpmconsulting rpmconsulting commented Feb 23, 2018

@brianteeman

This comment has been minimized.

Copy link
Contributor

@brianteeman brianteeman commented Feb 23, 2018

by putting your site into offline mode you have made the home page non-public

@rpmconsulting

This comment has been minimized.

Copy link

@rpmconsulting rpmconsulting commented Feb 23, 2018

@brianteeman

This comment has been minimized.

Copy link
Contributor

@brianteeman brianteeman commented Feb 23, 2018

Offline mode isnt the best way to develop your site privately as you have to be a logged in user and cant test it as a regular use - thats why I wrote this plugin for my own use abd share freely on github https://github.com/brianteeman/haraka

@waqas07

This comment has been minimized.

Copy link

@waqas07 waqas07 commented Sep 29, 2019

the problem will be solved to disable modsecurity from your hosting if you have shared hosting livechat will help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.