Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post installation message: Wrong php detection #16964

Closed
Klipper opened this issue Jul 4, 2017 · 24 comments

Comments

@Klipper
Copy link

commented Jul 4, 2017

Steps to reproduce the issue

Upgrade to Joomla 3.7.3
Read post installation message.

With me it says: .... Beginning with Joomla! 3.3, the version of PHP this site is using will no longer be supported. ...

Actually this site is using php 7.0.20 (Siteground)
See attached screencapture:
screen shot 2017-07-04 at 13 37 11

Expected result

No post installation message, because I'm using correct PHP version.

@davidbrooksio

This comment has been minimized.

Copy link

commented Jul 4, 2017

I can confirm that I also get this on PHP 7.1.6

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

Please go to the system information menu and confirm that it really is php 7 etc being reported on that page

@davidbrooksio

This comment has been minimized.

Copy link

commented Jul 4, 2017

7.1.6-1~ubuntu16.04.1+deb.sury.org+1 on one site and 7.1.6 on another.

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

sorry I see it now as well and can confirm the issue. I didnt read properly and thought you were talking about the php message on the home control panel of joomla and not the post install message

@mahagr

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

I'm not seeing the message in my Joomla installation after the update. There are just 3 messages in my updated installs (test sites):

Stats Collection in Joomla
Welcome to Joomla!
Two Factor Authentication is Available

@infograf768

This comment has been minimized.

Copy link
Member

commented Jul 4, 2017

Hmm, It looks like the file phpversion.php that used to be in /administrator/components/com_admin/postinstall/phpversion.php
is not present anymore to check the php version while the postinstall message is still present in the db

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

ah that is my fault then

@mahagr

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

I think it's leftover message after some older update, stored into db, just like @infograf768 said.

@infograf768

This comment has been minimized.

Copy link
Member

commented Jul 4, 2017

the file should not have been deleted, for people who update from a 3.2.x or earlier

@Bakual

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

the file should not have been deleted, for people who update from a 3.2.x or earlier

In 3.7, it's not relevant anymore and can be deleted. That was fine. The message has to be shown in 3.2, not in 3.7 (where it wouldn't work anymore anyway due to outdated PHP version).

@infograf768

This comment has been minimized.

Copy link
Member

commented Jul 4, 2017

therefore, i guess the db has to be corrected/updated

@mahagr

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

Why db should be corrected? The message came a long time ago after an update and the user hasn't marked the message to be hidden. It is just an old notification which later became obsolete after user updated PHP.

@Klipper

This comment has been minimized.

Copy link
Author

commented Jul 4, 2017

"The message came a long time ago after an update and the user hasn't marked the message to be hidden."

I never have seen this message in previous updates at all... And, I always hide these blue Post Installation Messages immediately. And yes I read these messages :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16964.

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

I never have seen this message in previous updates at all... And, I always hide these blue Post Installation Messages immediately. And yes I read these messages :-)

You wouldnt have seen it and therefore been able to hide it because the code was there to hide it as you were on a higher php version.

@mbabker

This comment has been minimized.

Copy link
Member

commented Jul 4, 2017

You wouldnt have seen it and therefore been able to hide it because the code was there to hide it as you were on a higher php version.

That. When the table was being read, the callback function defined in the file was preventing it from being displayed. That callback function doesn't exist anymore, so the component just shows the message since there's nothing to test it against.

So yes, the record should be removed from the database as well as the file being deleted since the intent is to not have the message at all anymore.

@Klipper

This comment has been minimized.

Copy link
Author

commented Jul 4, 2017

Agree, because I always try to use the latest stable php version. But probably because of missing /administrator/components/com_admin/postinstall/phpversion.php I get this message now with this latest update. I myself know I can ignore it, because I 'm sure I use correct phpversion, but may be other administrators can get confused...

If this issue will not be fixed, we will get this message now with each new update I assume...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16964.

@acs-ferreira

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

FYI, i've updated 4 websites from 3.7.2, same webserver, got the message on all of them.

@n9iels

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

Confirmed on all my installations. Also immediately a message from someone who was confused because he used PHP7 already and this message just popped up.

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

On the plus side at least it shows that some people notice the messages even if they dont understand/comprehend what they say

@richard67

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

I can confirm that, too, with PHP 7.1.6.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16964.

@ribo72

This comment has been minimized.

Copy link

commented Jul 4, 2017

Hello, i confirm this issue exist in joomla sites that the fresh install was in older joomla 3.x versions or migrated joomla sites from 1.5 or 2.5. I saw this issue in php 5.6.30 , 7.0.20, 7.1.6 . In system information show the correct php version

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

Please stop posting "me too"

@N6REJ

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2017

tracking

@infograf768

This comment has been minimized.

Copy link
Member

commented Jul 5, 2017

See PR #16974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.