Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A 404 error is thrown by Page Break plugin if pagination is used, without pagebreaks #17305

Closed
conflate-nl opened this issue Jul 27, 2017 · 11 comments

Comments

Projects
None yet
9 participants
@conflate-nl
Copy link
Contributor

commented Jul 27, 2017

This problem occurs when the Page Break plugin is enabled, and an article page uses a custom pagination feature for i.e. showing a list with extra items linked to an article, which if longer than 20 items, can be paginated using a JPagination object. This will result in the addition of the limitstart variable as an input var. This wasn't a problem before, but now with the modification in the Page Break plugin, this will throw a 404 error. Disabling the plugin makes the pages work normal again, and the custom list starts at page 2.

Steps to reproduce the issue

Make sure the Page Break plugin is enabled. Open an article page which hasn't got a pagebreak tag in the content. At the end of the url add ?limitstart=20

Expected result

The input var limitstart is at 20, so JPagination knows it's on page 2 (with limit set at 20)

Actual result

A 404 error

System information (as much as possible)

Joomla 3.7.3

Additional comments

Not sure when this error occured, could be in Joomla 3.7.2, but in 3.7.1 is was working fine.

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Jul 27, 2017

thanks for Report. Can you please look if #17127 is same Issue?

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

probably related to #11217

@conflate-nl

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2017

#17127 is not the problem, the problem is on pages which aren't using page breaks

@eriknzzz

This comment has been minimized.

Copy link

commented Jul 28, 2017

But #17127 is still my problem and I would appreciate some suggestions.

@ricardov03

This comment has been minimized.

Copy link

commented Aug 1, 2017

I present the same error in Joomla 3.7.4. I'm creating a custom module and I using the pagination.
The system return the same error when I have more then 1 page of products. Doesn't matter if you just have 1 product per page, the problem appears when I change the page with the pagination.

I see the variable that return the problem it's 'start' on the URL.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17305.

@julienlusson

This comment has been minimized.

Copy link

commented Aug 3, 2017

Same here, I've a module on an article page without page break in the text, but the module have multiple pages so, with this check only on the article text, if I click on the pagination I get a 404 error, if I disable the check from #11217 it works.

@loewl

This comment has been minimized.

Copy link

commented Aug 9, 2017

I can also confirm this error, after the upgrade to Joomla 3.7.4 a custom module that works with pagination through GET (?start=100) throws a 404 Page Not Found error, the debug mode shows pagebreak.php on top of the callstack.
After deactivating the plugin, the pagination works correctly again.

@ReLater

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2018

I've written a plugin that works partially similiar like plg_content_pagebreak with a toc and JPagination.

I get the described 404 error if plg_content_pagebreak is activated and the article contains no class="system-pagebreak" is present in the article.

#11217 is wrong!

@ReLater

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2018

Please test #21290 and be loud if not accepted.

@joomla-cms-bot

This comment has been minimized.

Copy link

commented Jul 29, 2018

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Jul 29, 2018

closed as having Pull Request #21290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.