New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP broken in 3.8 #17989

Closed
arraylabs opened this Issue Sep 19, 2017 · 13 comments

Comments

Projects
None yet
7 participants
@arraylabs

arraylabs commented Sep 19, 2017

Steps to reproduce the issue

Configure LDAP, try to login with LDAP user

Expected result

LDAP to authenticate properly, currently failing with line 119 of ldap.php file.

Actual result

Currently failing with line 119 of ldap.php file, specifically the $ldap->escape method that upon further inspection does not exist in the LdapClient.php file.

System information (as much as possible)

LAMP, php 6.x, J3.8

Additional comments

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Sep 19, 2017

Member

Replace the file with https://github.com/joomla-framework/ldap/blob/1.2.0/src/LdapClient.php

Apparently some pull request updating the file didn't get applied (or submitted?).

Member

mbabker commented Sep 19, 2017

Replace the file with https://github.com/joomla-framework/ldap/blob/1.2.0/src/LdapClient.php

Apparently some pull request updating the file didn't get applied (or submitted?).

@mbabker mbabker added this to the Joomla 3.8.1 milestone Sep 19, 2017

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Sep 19, 2017

Member

d35924e fixes this. Will be included in 3.8.1.

Leaving this open for a little bit just so we don't get a plethora of similar opened issues.

Member

mbabker commented Sep 19, 2017

d35924e fixes this. Will be included in 3.8.1.

Leaving this open for a little bit just so we don't get a plethora of similar opened issues.

mbabker added a commit that referenced this issue Sep 19, 2017

@arraylabs

This comment has been minimized.

Show comment
Hide comment
@arraylabs

arraylabs Sep 19, 2017

Appreciate it, thanks!!

arraylabs commented Sep 19, 2017

Appreciate it, thanks!!

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman
Contributor

brianteeman commented Sep 19, 2017

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.8.1 milestone Sep 20, 2017

@kdhoe1

This comment has been minimized.

Show comment
Hide comment
@kdhoe1

kdhoe1 Sep 21, 2017

This sollution doesn't work with registered users, only super users can login
regards

kdhoe1 commented Sep 21, 2017

This sollution doesn't work with registered users, only super users can login
regards

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Sep 21, 2017

Member

@kdhoe1 not knowing anything more about your problem I can say with certainty that your problem is not related to this issue and you should file a separate report with appropriate details.

Member

mbabker commented Sep 21, 2017

@kdhoe1 not knowing anything more about your problem I can say with certainty that your problem is not related to this issue and you should file a separate report with appropriate details.

@kdhoe1

This comment has been minimized.

Show comment
Hide comment
@kdhoe1

kdhoe1 Sep 21, 2017

before update to version 3.8.0 no issues during logon of all users through ldap in frontend.
after update: 0 - Call to undefined method Joomla\Ldap\LdapClient::escape() for all users
when replacing ldap file, only super users can login, regular users get: 0 - Class 'Joomla\Ldap\LdapClient' not found
???

kdhoe1 commented Sep 21, 2017

before update to version 3.8.0 no issues during logon of all users through ldap in frontend.
after update: 0 - Call to undefined method Joomla\Ldap\LdapClient::escape() for all users
when replacing ldap file, only super users can login, regular users get: 0 - Class 'Joomla\Ldap\LdapClient' not found
???

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Sep 21, 2017

Member

Then you have not replaced the file correctly as the file contains that class.

Member

mbabker commented Sep 21, 2017

Then you have not replaced the file correctly as the file contains that class.

@kdhoe1

This comment has been minimized.

Show comment
Hide comment
@kdhoe1

kdhoe1 Sep 21, 2017

just deleted the file on the server and copied the new file
is there another way?

regards

kdhoe1 commented Sep 21, 2017

just deleted the file on the server and copied the new file
is there another way?

regards

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Sep 21, 2017

Member

If you downloaded the HTML page and used that, then that would break it. Make sure you hit the "raw" button on the page so you get the actual PHP file that should be uploaded without any extra HTML. Additionally, the file must be uploaded with the correct casing in the name otherwise the file loader won't pick it up.

Member

mbabker commented Sep 21, 2017

If you downloaded the HTML page and used that, then that would break it. Make sure you hit the "raw" button on the page so you get the actual PHP file that should be uploaded without any extra HTML. Additionally, the file must be uploaded with the correct casing in the name otherwise the file loader won't pick it up.

@kdhoe1

This comment has been minimized.

Show comment
Hide comment
@kdhoe1

kdhoe1 Sep 21, 2017

OK, Big thanks, it works

Regards

Kris

kdhoe1 commented Sep 21, 2017

OK, Big thanks, it works

Regards

Kris

@mbabker mbabker closed this Sep 21, 2017

@EHJ-52n

This comment has been minimized.

Show comment
Hide comment
@EHJ-52n

EHJ-52n Sep 22, 2017

We had the same error and the solution with replacing the libraries/vendor/joomla/ldap/src/LdapClient.php with the new version solved the issue for us!

EHJ-52n commented Sep 22, 2017

We had the same error and the solution with replacing the libraries/vendor/joomla/ldap/src/LdapClient.php with the new version solved the issue for us!

@gojets

This comment has been minimized.

Show comment
Hide comment
@gojets

gojets Sep 27, 2017

Thanks mbabker! The fix works for me.

gojets commented Sep 27, 2017

Thanks mbabker! The fix works for me.

@mbabker mbabker added this to the Joomla 3.8.1 milestone Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment