New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix how modals are displayed #22044

Open
wilsonge opened this Issue Sep 7, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@wilsonge
Copy link
Contributor

wilsonge commented Sep 7, 2018

#21847 and #21852 have both been proposed as ways to solve where modals are inserted on the page. Clearly neither are optimal solutions. I've merged 21487 to allow patchtester to work for now. But we need to come up with a better solution before stable

@coolcat-creations

This comment has been minimized.

Copy link
Contributor

coolcat-creations commented Sep 8, 2018

Can we display the notifications as pushdown instead of modals?

@wilsonge

This comment has been minimized.

Copy link
Contributor Author

wilsonge commented Sep 8, 2018

If we can find someone sufficiently well versed in javascript to do it sure

@brianteeman brianteeman added the J4 Issue label Sep 8, 2018

@chmst

This comment has been minimized.

Copy link
Contributor

chmst commented Dec 26, 2018

Same problem with Versions. The contenthistory-modal is overlayed by the backdrop layer (found in contacts and articles). So some improvements concerning a11y must wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment