New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] [RFC] Cassiopeia template does not use dropdowns for menus with submenus in module position "menu" #22930
Comments
What would be prefered here?... Some options...
|
Good questions. I have no idea about what is the standard way in Joomla 4, that's why I was not able to make a PR myself. |
The more I look into the scss and js, the less I think I have the knowledge to make a PR myself. @wilsonge As you are the release lead: Do you know which of the options mentioned above by @ciar4n is the most appropriate for 4.0? Or do you know who knows? What is the status of and the plan about the de-bootstrapification of the 4.0 core? Shall Cassiopeia be a bootstrap template or not? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22930. |
Yes it is a bootstrap template
There isn't one. We're dropping jQuery as much as we can and obviously if there's no need to use bootstrap don't use it. But if there is a need for bootstrap use it. There's a reason we've upgraded to bootstrap 4, not dropped bootstrap...
In all our examples our menu is designed to be a vertical dropdown effectively. So actually I'm kinda happy with not editing the core menu module. I'd shove an alternate layout in the template for a bootstrap vertical dropdown people can use if they want (which uses bootstrap) |
And why does the preview image of the Cassiopeia template then show a vertical menu at the top, left beside the search box? It should be possible to at least have dropdowns for a menu at that module position. That module position is even called "menu", so it was desired to be the place for a kind of main menu of a site, which is also what Bootstrap suggests to have at that place. The more I look into the Cassiopeia details, the more I think it is an either unfinished or somehow later broken work which has no consistency in the use of Boostrap CSS or own CSS classes. The standard site template of Joomla should be a show case on how things should be done, so either should be a basic template which does not require Bootstrap at all, but if it is a Bootstrap template like you say, then it should support Bootstrap classes like "nav-pills". But currently it does not support that at all. On the other hand, our blog sample date still uses the "nav-pills", see my closed PR #23023 . This all seems not consistent to me and makes me think what I mentioned above: Either unfinished or somehow broken. |
For a bit of history on this template, here are couple of the more significant styling PRs.. Initial template by @C-Lodder .. #14864 And that is pretty much it. There has not been much discussion on what is expected of the template and I don't think it was ever considered 'finished'. |
@ciar4n I start to understand a bit which way it goes. Much stuff to read, will try to dig into it. @wilsonge Do I get you right, you think it should be an alternative layout in a template override, so below the html sub-folder of the template? If so, does this desciption for Joomla 3 also apply for Joomla 4? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22930. |
I started to work on it a bit but then focused on other stuff. I will close this issue and if necessary open a new one when I continue on that subject. |
Hi, |
No, there has not been a solution for this yet. |
Steps to reproduce the issue
Install 4.0-alpha5-dev.
Login to administrator area (backend).
Install blog sample data.
Change module position of site module "Author Menu" to position "menu".
Go to the site (frontend) and log in.
Log in is needed because "Author Menu" is used, which is the only example in blog sample data which has submenus, but it would be the same without login with any other menu which has submenus.
Expected result
Menu module uses dropdown for menu items with submenus.
Actual result
No dropdowns are used, menu looks really bad, see red mark in following screenshot:
System information (as much as possible)
Doesn't matter, happens with any Joomla 4.0 version.
Additional comments
In general menu styles seem not to be complete in the Cassiopeia template, e.g. "nav-pills" does not work in any module position.
This is a huge functional downgrade compared to the Protostar template of Joomla 3.
@ciar4n Please check and comment.
The text was updated successfully, but these errors were encountered: