Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Webauthn image is 4359px x 3260px #30180

Closed
PhilETaylor opened this issue Jul 24, 2020 · 2 comments
Closed

[4.0] Webauthn image is 4359px x 3260px #30180

PhilETaylor opened this issue Jul 24, 2020 · 2 comments
Labels
No Code Attached Yet

Comments

@PhilETaylor
Copy link
Contributor

PhilETaylor commented Jul 24, 2020 •
edited

Steps to reproduce the issue

view 3 images in https://github.com/joomla/joomla-cms/tree/4.0-dev/build/media_source/plg_system_webauthn/images

Expected result

A small image optimised dimensions and file size

Actual result

4359px x 3260px !!

Performance tools show this as an overhead of over 200kb+ per image

webauthn-black

System information (as much as possible)

Additional comments

Maybe run a full repo image optimiser over all the new Joomla 4 images, as has been done over Joomla 1/2/3 images over the years ...
@brianteeman
Copy link
Contributor

ouch - good spot

brianteeman added a commit to brianteeman/joomla-cms that referenced this issue Oct 1, 2020
@brianteeman
[4.0] resize webauthn logo
d81e14b 
PR for joomla#30180

No need to load a 200kb image when its only being displayed on a button
@brianteeman brianteeman mentioned this issue Oct 1, 2020
Merged
@Quy
Copy link
Contributor

Quy commented Oct 1, 2020

PR #30846

@Quy Quy closed this as completed Oct 1, 2020
HLeithner pushed a commit that referenced this issue Oct 6, 2020
@brianteeman
[4.0] resize webauthn logo (#30846)
348da1a 
PR for #30180

No need to load a 200kb image when its only being displayed on a button
sakiss pushed a commit to sakiss/joomla-cms that referenced this issue Oct 16, 2020
@brianteeman @sakiss
[4.0] resize webauthn logo (joomla#30846)
240da31 
PR for joomla#30180

No need to load a 200kb image when its only being displayed on a button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
No Code Attached Yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Quy @PhilETaylor @brianteeman @joomla-cms-bot