Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Uncaught TypeError: e.editors is undefined #42056

Closed
Quy opened this issue Oct 5, 2023 · 9 comments
Closed

[5.0] Uncaught TypeError: e.editors is undefined #42056

Quy opened this issue Oct 5, 2023 · 9 comments

Comments

@Quy
Copy link
Contributor

Quy commented Oct 5, 2023

mail-templates

Steps to reproduce the issue

Edit a mail template.
Insert a tag.
See browser console.

Additional comments

Not an issue in v4.4.

@richard67
Copy link
Member

Looks as if conditional chaining could also be helpful here ... ping @dgrammatiko .

@dgrammatiko
Copy link
Contributor

I’ll have a look in a bit, unless @Fedik could patch it

@Fedik
Copy link
Member

Fedik commented Oct 5, 2023

It looks like the script missing editors dependency

@Fedik
Copy link
Member

Fedik commented Oct 5, 2023

Hm, no, I cannot reproduce it on latest 5.0-dev branch,
anything special need to do?

@dgrammatiko
Copy link
Contributor

@Fedik you were right, #42058

@Fedik
Copy link
Member

Fedik commented Oct 5, 2023

okay

@richard67
Copy link
Member

Closing as having a pull request. Please test #42058 . Thanks in advance.

@dgrammatiko
Copy link
Contributor

@Fedik kinda irrelevant but could we skip the console.warn on the .min.js and only have it in the .js (debug)? I'm talking about this:
Screenshot 2023-10-05 at 16 33 23

@Fedik
Copy link
Member

Fedik commented Oct 5, 2023

Can skip, but I did not wanted to bother with it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants