New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap.rtl.min.css FORGOTTEN #42653
Comments
|
I suggest that the default templates (cassiopeia / atum) should also use the original bootstrap and provide another item in joomla.asset.json to customize the colors. |
|
No not forgotten at all. I suggest that you look more closely at the code before posting. Joomla works perfectly in RTL and LTR |
|
I suggest that instead of sending such a message, introduce the relevant file. Make it clear so that this page can be useful to other developers as well. |
|
@brianteeman they talk about the ancient HTMLHelper: joomla-cms/libraries/src/HTML/Helpers/Bootstrap.php Lines 628 to 634 in 1a5a37c
|
|
@brianteeman When you download Bootstrap zip file from official site, you have some files... please imagine that you will add similar bootstrap toolkit to vendor folder... So I need original that project... FOR EXAMPLE the best is: Bootstrap version 5 support RTL but Joomla/media/vendor NOT SUPPORT RTL... |
|
when use |
|
@sinahaghparast is right. The From my point of view it is "simple" to add them. See: https://github.com/joomla/joomla-cms/blob/5.0.2/build/build-modules-js/settings.json#L44-L52 rtl files are missing there. And it would be nice to have an additional WAM asset for loading: See Afterwards it's trivial to fix the HTMLHelper thing by using the rtl WAM asset. |
Please submit a pull request but not for changing anything with the existing templates as they are correct |
The steps are just copy/paste steps with no influence on any compilation (SCSS or so). They just add some files into vendor/bootstrap/css and new assets in
Really sorry but I won't. I have just tested quickly that my proposal could/should work. |
|
I understand that in the development process, changes even though band modifications may require time and energy. However, the mentioned case is logical and correct and is suggested as a user who is developing in the Joomla community. It is encouraging if we show new friends the right path in Joomla development and modifications and support their logical cases, so that they can also be accompanied as future Joomla developers... @sinahaghparast |
|
From my point of view any of these files should be copied during build procedure into https://github.com/twbs/bootstrap/tree/v5.3.2/dist/css and any Now for example these questions come up when I look at https://github.com/joomla/joomla-cms/blob/5.0.2/build/build-modules-js/settings.json#L44-L52 (and following lines there):
Is it inconsistency or by purpose? Or was it just never adjusted? A pr will end in one of these endless and annoying discussions and when the pr is RTC (which needs some testers) somebody will block/move it because of this or that. It should be clear in advance what the goal is. |
What needs to be fixed
bootstrap RTL version not exist in
/media/vendor/bootstrap/css
/media/vendor/bootstrap/scss
/media/vendor/joomla.asset.json
bootstrap.rtl.min.css not exist
Why this should be fixed
https://getbootstrap.com/docs/5.3/getting-started/rtl/
How would you fix it
please locate rtl version bootstrap in joomla!
Side Effects expected
The text was updated successfully, but these errors were encountered: