Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help button fails to open help screen when clicked on the question mark #42818

Closed
chrisdavenport opened this issue Feb 15, 2024 · 6 comments
Closed

Comments

@chrisdavenport
Copy link
Contributor

Steps to reproduce the issue

Go to any screen which has a help screen, for example Content -> Articles.
Click on the text "Help" of the help toolbar button and you will see the appropriate help screen. However, if you click on the question mark to the left of the text you will get a much larger blank window with "about:blank" in the address bar.

Expected result

Clicking anywhere on the help button (even on the question mark) should open the appropriate help screen.

Actual result

The help screen only opens if the user clicks on the text of the help button.

System information (as much as possible)

Chrome on Ubuntu 22.04.
php 8.1
Joomla 4.4.2 and Joomla 5.0.2 (same behaviour on both).

@brianteeman
Copy link
Contributor

Confirmed. Clicking exactly on the icon opens a blank window

@Quy Quy added the bug label Feb 15, 2024
@Quy
Copy link
Contributor

Quy commented Feb 15, 2024

In browser's console: Opening multiple popups was blocked due to lack of user activation.

@dgrammatiko line 49 #39727

@dgrammatiko
Copy link
Contributor

dgrammatiko commented Feb 15, 2024

@Quy can you add this css and check:

.btn > * { pointer-events: none; }

Ok, checked it myself, the code above fixes the bug. It needs to be added to the atum scss

@Quy
Copy link
Contributor

Quy commented Feb 15, 2024

@dgrammatiko I will submit a PR. Thank you for the fix!

@dgrammatiko
Copy link
Contributor

dgrammatiko commented Feb 15, 2024

@Quy change the code to button > * { pointer-events: none; }. the .btn class could be applied to links also...

Ignore this, the PR is fine

@Quy
Copy link
Contributor

Quy commented Feb 15, 2024

Thanks for the report. Please test #42820.

@Quy Quy closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants