Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "one word aliases of categories treated as articles" with adv… #10261

Closed
wants to merge 8 commits into from

Conversation

Projects
None yet
4 participants
@alex7r
Copy link
Contributor

commented May 6, 2016

Summary of Changes

Include advanced SEF enabled check

Testing Instructions

Enable advanced SEF
Create Category
Create Sub-category (one word alias)
Create article in sub-category

Link menu Item to Category

Bug result

Category can be accessed
Article in sub-category can be accessed
Sub-category can't be accessed because it treated as article(while having one word alias) and article not found

Fix result

Category can be accessed
Sub-category can be accessed
Articles of all levels can be accessed

alex7r and others added some commits May 6, 2016

Can not pass build check PHP 5.6 FIX
mysql_connect(): The mysql extension is deprecated and will be removed in the future: use mysqli or PDO instead: 1x
    1x in JDatabaseDriverMysqlTest::testDropTable

@wojsmol wojsmol referenced this pull request May 6, 2016

Merged

CS fix for Travis #1

@wojsmol

This comment has been minimized.

Copy link
Contributor

commented May 6, 2016

@alex7r Please see alex7r#1

alex7r added some commits May 6, 2016

nl
@alex7r

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2016

Passed checks with Build #23692


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10261.

@wilsonge

This comment has been minimized.

Copy link
Contributor

commented May 7, 2016

https://github.com/joomla/joomla-cms/blob/3.6.x/components/com_content/router.php

We have totally rewritten this in the 3.7 branch there. The advanced router is not a documented feature so I'm going to close this PR as its not a usable feature and it's being removed soon anyhow

@wilsonge wilsonge closed this May 7, 2016

@alex7r

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2016

It may be not documented, but planing on removing it - is like planing on giving Joomla big disadvantage.
It's a good idea if you want to maintain value of SEF extensions wich making Joomla sites scare people and blocking Joomla community from it's growth.
Really, advanced SEF is mast have feature and it's working.(working on a live site, 3000+ visits per day about an year) There little problem with triggering 404 page, but it can be managed by checking current URL and distanation URL to match(can provide my code).
And if you think that standard routing is what people need - no, SEO asks to exclude 'id-' from URL.
So to summarize: cut out advanced SEF - give people one more reason to say "oh, joomla? I'm out".
Joomla must be for everyone, not for "everyone who don't bother about his site".

p.s. sorry for "fire in the hole" on this one, but each talk with people who prefer anything against Joomla is like knife in heart for me. And you planning to give this people one more real reason to refuse to show love to J!
You can email me for more details on "why SEF extensions are bad" and "what people need to have in core" and any other feedback.

Thanks. And don't cut it off...

@wilsonge

This comment has been minimized.

Copy link
Contributor

commented May 8, 2016

We have #10170 as an alternative for removing ids from URLs

@alex7r

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2016

oh, well, if it gonna make it into, then it's okay
mean it's okay if in the core there will be way to do it
thanks for clarifying this for me

@wilsonge

This comment has been minimized.

Copy link
Contributor

commented May 8, 2016

It's ok :) Advanced routing was basically an experiment for 1.6 that never got finished by Hannes. This is the actual production ready code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.