New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare the document variable #10839

Merged
merged 1 commit into from Jul 16, 2016

Conversation

Projects
None yet
6 participants
@mbabker
Copy link
Member

mbabker commented Jun 16, 2016

Summary of Changes

JControllerLegacy::display() injects a JDocument instance into JViewLegacy objects here. There is not a JViewLegacy::$document class member variable defined. Now there is.

Testing Instructions

Review.

@zero-24

This comment has been minimized.

Copy link
Contributor

zero-24 commented Jun 16, 2016

Should we include a @SInCE tag?

@mbabker

This comment has been minimized.

Copy link
Member

mbabker commented Jun 16, 2016

Someone should do it for all of the properties here, I didn't because none have it and I don't feel like digging back to determine when the variable was actually introduced.

@grhcj

This comment has been minimized.

Copy link

grhcj commented Jun 17, 2016

I have tested this item successfully on 2e5a835

On code Review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10839.

1 similar comment
@zero-24

This comment has been minimized.

Copy link
Contributor

zero-24 commented Jun 17, 2016

I have tested this item successfully on 2e5a835

On code Review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10839.

@zero-24

This comment has been minimized.

Copy link
Contributor

zero-24 commented Jun 17, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10839.

@joomla-cms-bot joomla-cms-bot added the RTC label Jun 17, 2016

@photodude

This comment has been minimized.

Copy link
Contributor

photodude commented Jun 19, 2016

I think all of the variables were introduced at or before platform 11.1, and before the use of github for the version histories.

@roland-d roland-d added this to the Joomla 3.6.1 milestone Jul 16, 2016

@roland-d roland-d merged commit f3381fb into joomla:staging Jul 16, 2016

2 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Jul 16, 2016

@mbabker mbabker deleted the mbabker:JViewLegacy-document branch Jul 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment