Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactory com_banners tracks export modal + new toolbar button layout #10934
Summary of Changes
Download Tracks Modal:
New Generic Toolbar Button Layout:
To be tested on staging or 3.6.0-beta
referenced this pull request
Jun 26, 2016
@JoomliC Thanks for fixing tooptip issue.
Thanks @RonakParmar for feedback!
But, if an issue with scrolling, should be related to this one (dynamically add of scrolling): #9817
So, could you attached a screenshot of issue, as well as some information: screnn size, browser and its version, OS ?
Here is my system information as much as possible:
Joomla! Version : Joomla! 3.6.0-beta2 Beta [ Noether ] 16-June-2016 13:54 GMT
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934.
@RonakParmar you screen shot shows no issue in scrolling (i mean it works as expected, and that's good!).
@brianteeman does 50vh height was ok for you in Isis test of this PR ? (or a 60vh height could be better: https://github.com/joomla/joomla-cms/pull/10934/files#diff-4b21245c193bec415dbe082fd9486de3R96 ?)
@RonakParmar Thanks for screen size!
Could you test back this PR with this minor adjustment, thanks!