Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactory com_banners tracks export modal + new toolbar button layout #10934

Merged
merged 16 commits into from Jul 16, 2016

Conversation

Projects
None yet
7 participants
@JoomliC
Copy link
Contributor

commented Jun 26, 2016

Pull Request for Issue #10911 & PR #10927 (improve it).

Summary of Changes

Download Tracks Modal:

  • Fix and improve HTML rendering (use renderField)
  • No tooltip for File Name, as description is a bit long (and not always easy to use tooltip when long description).
  • New form field type note for File Name description in a alert-info style.
  • Tooltip placement bottom for Compressed label (prevent tooltip cropped at top when in iframe)
  • Buttons in the BS modal footer
  • Using new viewport dimensions
  • HATHOR : modal was broken! This PR fixes it in Hathor Template, and add overrides to adapt rendering.

New Generic Toolbar Button Layout:

  • appendButton using a new toolbar button layout:
$selector = $displayData['selector'];
$class    = isset($displayData['class']) ? $displayData['class'] : 'btn btn-small';
$icon     = isset($displayData['icon']) ? $displayData['icon'] : 'out-3';
$text     = isset($displayData['text']) ? $displayData['text'] : '';
?>
<button class="<?php echo $class; ?>" data-toggle="modal" data-target="#<?php echo $selector; ?>">
    <span class="icon-<?php echo $icon; ?>"></span>
    <?php echo $text; ?>
</button>

Testing Instructions

To be tested on staging or 3.6.0-beta

  • Test on Isis template (api) and Hathor template (overrides)
  • Go to Components > Banners > Tracks
  • Click on Export toolbar button
  • Check tooltip placement
  • Test Cancel and Export buttons now in modal footer

Isis admin template
Before:
capture d ecran 2016-06-26 a 20 42 47

After:
capture d ecran 2016-06-25 a 17 04 16

Hathor admin template
Before:
capture d ecran 2016-06-26 a 20 37 30

After:
capture d ecran 2016-06-26 a 20 38 40

@RonakParmar

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2016

@JoomliC Thanks for fixing tooptip issue.
One suggestion: I have applied this latest PR and found that we have scroll-bar in our iframe modal.
Checked that .jviewport-height50 { height: 50vh;} applied, Is it possible to set height:60vh or Is it dynamically applied to iframe?
It will remove the scroll-bar and will look nice.

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2016

I have tested this item successfully on 215efce


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934.

@JoomliC

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2016

One suggestion: I have applied this latest PR and found that we have scroll-bar in our iframe modal.
Checked that .jviewport-height50 { height: 50vh;} applied, Is it possible to set height:60vh or Is it dynamically applied to iframe?

Thanks @RonakParmar for feedback!
About new modal parameters for modal introduced in 3.6.0, this is set in the view here: https://github.com/joomla/joomla-cms/pull/10934/files#diff-4b21245c193bec415dbe082fd9486de3R96
(viewport dimensions introduced with this PR : #10388)

But, if an issue with scrolling, should be related to this one (dynamically add of scrolling): #9817

So, could you attached a screenshot of issue, as well as some information: screnn size, browser and its version, OS ?
It could help to see where your issue comes from (as scrolling should appear only when modal body content is too high for the rendered modal).

Thanks!

@RonakParmar

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2016

Here is my system information as much as possible:
PHP Built On : Linux 126-UBUNTU 3.5.0-54-generic #81precise1-Ubuntu SMP Tue Jul 15 04:02:22 UTC 2014 x86_64
Database Version : 5.5.49-0ubuntu0.12.04.1
PHP Version : 5.4.45-3+donate.sury.org
precise+3
Web Server : Apache/2.2.22 (Ubuntu)

Joomla! Version : Joomla! 3.6.0-beta2 Beta [ Noether ] 16-June-2016 13:54 GMT
Joomla! Platform Version : Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent : Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934.

@RonakParmar

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2016

screen shot 2016-06-27 at 05 29 01


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934.

@JoomliC

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2016

@RonakParmar you screen shot shows no issue in scrolling (i mean it works as expected, and that's good!).
But your screen view is a bit "panoramic".
Is it a resized window or a standard view of your device? (as 50/100 viewport height for standard screen size seems ok...)

@brianteeman does 50vh height was ok for you in Isis test of this PR ? (or a 60vh height could be better: https://github.com/joomla/joomla-cms/pull/10934/files#diff-4b21245c193bec415dbe082fd9486de3R96 ?)

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2016

After applying the PR it looks fine to me

@RonakParmar

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2016

It's a standard view of my device, I do not change my screen size.
Screen resolution: 19"
1366 x 768 (16:9)

@joomla-cms-bot

This comment has been minimized.

Copy link

commented Jun 27, 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934.

@JoomliC

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2016

Thanks @brianteeman ! I have just updated a little the PR by not using viewport height which may not change a bit for you, and then works too for @RonakParmar's screen size ;-)

@RonakParmar Thanks for screen size!
Tested and confirm that's not good with this screen size.
In the same time, as the content is not high, i have removed the viewport height, to use only the ifram height, set now to 370px which seems to be the good value for this content.

Could you test back this PR with this minor adjustment, thanks!

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2016

I have tested this item successfully on 5340062


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934.

@RonakParmar

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2016

I have tested this item successfully on 5340062

No scroll-bar now. @JoomliC Thank you to fix this.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934.

@kalpeshtailored

This comment has been minimized.

Copy link

commented Jun 27, 2016

I have tested this item successfully on 5340062


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934.

@JoomliC

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2016

Thanks everybody for testing 👍

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2016

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10934.

@joomla-cms-bot joomla-cms-bot added the RTC label Jun 27, 2016

@roland-d roland-d added this to the Joomla 3.6.1 milestone Jul 16, 2016

@roland-d roland-d merged commit af93af4 into joomla:staging Jul 16, 2016

2 checks passed

JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zero-24

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2016

@joomla-cms-bot please let me know if you have holiday too than we can take that tasks 🌴

@roland-d roland-d removed the RTC label Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.